From: gangadharv <[email protected]>
Fixed a Coding style issue.
Signed-off-by: Gangadhar V <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index d61842e..da19145 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
tx_ra_bitmap |= ((raid<<28)&0xf0000000);
DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
- __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
+ __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
/* bitmap[0:27] = tx_rate_bitmap */
/* bitmap[28:31]= Rate Adaptive id */
--
1.7.9.5
Gangadhar,
On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> From: gangadharv <[email protected]>
>
> Fixed a Coding style issue.
>
> Signed-off-by: Gangadhar V <[email protected]>
Your Signed-off-by doesn't much your From line.
Also, is this the full name you would use to sign off with on
legal documents?
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index d61842e..da19145 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
> tx_ra_bitmap |= ((raid<<28)&0xf0000000);
>
> DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
> - __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
> + __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
>
> /* bitmap[0:27] = tx_rate_bitmap */
> /* bitmap[28:31]= Rate Adaptive id */
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
Gangadhar,
On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> From: gangadharv <[email protected]>
>
> Fixed a Coding style issue.
The description needs to be more specific? What type of issue did you
fix? How did you find this issue?
[...]
--
- Jeremiah Mahler
Hi,
It is Space coding Style issue which i found when running
checkpatch.pl script on rtw_ap.c.
--Gangadhar V
On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler <[email protected]> wrote:
> Gangadhar,
>
> On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
>> From: gangadharv <[email protected]>
>>
>> Fixed a Coding style issue.
>
> The description needs to be more specific? What type of issue did you
> fix? How did you find this issue?
>
> [...]
>
> --
> - Jeremiah Mahler
Gangadhar,
On Sat, Dec 20, 2014 at 03:13:10PM +0530, Gangadhar V wrote:
> Hi,
> It is Space coding Style issue which i found when running
> checkpatch.pl script on rtw_ap.c.
>
> --Gangadhar V
> On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler <[email protected]> wrote:
> > Gangadhar,
> >
> > On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> >> From: gangadharv <[email protected]>
> >>
> >> Fixed a Coding style issue.
> >
> > The description needs to be more specific? What type of issue did you
> > fix? How did you find this issue?
> >
Good, now describe this in the log message and submit a second
version of the patch.
> > [...]
> >
> > --
> > - Jeremiah Mahler
--
- Jeremiah Mahler