2014-12-22 20:50:20

by samuel kihahu

[permalink] [raw]
Subject: [PATCH] staging: lustre: cleanup align switch and case

From: skihahu <[email protected]>

Align switch and case to be at the same indent.

Signed-off-by: samuel kihahu <[email protected]>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;

switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}


2014-12-22 21:18:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> From: skihahu <[email protected]>
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <[email protected]>

The "From:" and "Signed-off-by:" names don't match, which doesn't make
much sense, right? Please fix and resend.

2014-12-23 04:38:20

by samuel kihahu

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote:
> On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> > From: skihahu <[email protected]>
> >
> > Align switch and case to be at the same indent.
> >
> > Signed-off-by: samuel kihahu <[email protected]>
>
> The "From:" and "Signed-off-by:" names don't match, which doesn't make
> much sense, right? Please fix and resend.
>

I have corrected as requested above.


Attachments:
(No filename) (437.00 B)
0001-staging-lustre-cleanup-align-switch-and-case.patch (1.99 kB)
Download all attachments

2014-12-23 05:58:24

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

On Tue, Dec 23, 2014 at 07:38:04AM +0300, samuel kihahu wrote:
> On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote:
> > On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> > > From: skihahu <[email protected]>
> > >
> > > Align switch and case to be at the same indent.
> > >
> > > Signed-off-by: samuel kihahu <[email protected]>
> >
> > The "From:" and "Signed-off-by:" names don't match, which doesn't make
> > much sense, right? Please fix and resend.
> >
>
> I have corrected as requested above.

> >From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001
> From: samuel kihahu <[email protected]>
> Date: Mon, 22 Dec 2014 18:16:29 +0300
> Subject: [PATCH] staging: lustre: cleanup align switch and case
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <[email protected]>
> ---
> drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
> 1 file changed, 25 insertions(+), 25 deletions(-)

But this isn't in a form I can apply, please resend in a format I don't
have to hand-edit the email.

greg k-h