2014-12-23 07:58:45

by samuel kihahu

Subject: [PATCH] staging: lustre: cleanup align switch and case

From: samuel kihahu <[email protected]>

Align switch and case to be at the same indent.

Signed-off-by: samuel kihahu <[email protected]>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;

switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}

2014-12-23 08:54:58

by Dan Carpenter

Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <[email protected]>

Don't include this unless you are forwarding a patch on behalf of the
original author. Also the capitalization isn't correct. These things
are intended to be a bit formal like signing a legal document.

regards,
dan carpenter

2014-12-23 09:37:03

by Jeremiah Mahler

Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

samuel,

This patch is corrupt and won't apply. I suspect it is due to missing
spaces at the start of each line in the diff.

I recommend using 'git send-email'. But if you are using a different
client have a look at Documentation/email-clients.txt for tips on how to
avoid these problems.

On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <[email protected]>
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <[email protected]>
> ---
> drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index 6dd4309..b5f07fa 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -61,31 +61,31 @@ lnet_selftest_fini(void)
> int i;
>
> switch (lst_init_step) {
> - case LST_INIT_CONSOLE:
> - lstcon_console_fini();
> - case LST_INIT_FW:
> - sfw_shutdown();
> - case LST_INIT_RPC:
> - srpc_shutdown();
> - case LST_INIT_WI_TEST:
> - for (i = 0;
> - i < cfs_cpt_number(lnet_cpt_table()); i++) {
> - if (lst_sched_test[i] == NULL)
> - continue;
> - cfs_wi_sched_destroy(lst_sched_test[i]);
> - }
> - LIBCFS_FREE(lst_sched_test,
> - sizeof(lst_sched_test[0]) *
> - cfs_cpt_number(lnet_cpt_table()));
> - lst_sched_test = NULL;
> -
> - case LST_INIT_WI_SERIAL:
> - cfs_wi_sched_destroy(lst_sched_serial);
> - lst_sched_serial = NULL;
> - case LST_INIT_NONE:
> - break;
> - default:
> - LBUG();
> + case LST_INIT_CONSOLE:
> + lstcon_console_fini();
> + case LST_INIT_FW:
> + sfw_shutdown();
> + case LST_INIT_RPC:
> + srpc_shutdown();
> + case LST_INIT_WI_TEST:
> + for (i = 0;
> + i < cfs_cpt_number(lnet_cpt_table()); i++) {
> + if (lst_sched_test[i] == NULL)
> + continue;
> + cfs_wi_sched_destroy(lst_sched_test[i]);
> + }
> + LIBCFS_FREE(lst_sched_test,
> + sizeof(lst_sched_test[0]) *
> + cfs_cpt_number(lnet_cpt_table()));
> + lst_sched_test = NULL;
> +
> + case LST_INIT_WI_SERIAL:
> + cfs_wi_sched_destroy(lst_sched_serial);
> + lst_sched_serial = NULL;
> + case LST_INIT_NONE:
> + break;
> + default:
> + LBUG();
> }
> return;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
- Jeremiah Mahler