From: Kroderia <[email protected]>
Delete a useless white space line according to the coding style.
Signed-off-by: Ben Chan <[email protected]>
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 85bd7d0..899078f 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
return 0;
-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
--
1.7.10.4
On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
> From: Kroderia <[email protected]>
So very very close to being correct. Also I think someone may have
already sent this one but it just hasn't been applied because the merge
window is open. I've definitely seen this line before...
regards,
dan carpenter
On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
> People say that is not a legal name, therefore I create this English name sound like my real name.
>
I'm confused. So Ben Chan isn't your real name, just one you made up?
> > On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler <[email protected]> wrote:
> >
> > On Tue, Dec 23, 2014 at 03:37:53PM +0000, Kroderia wrote:
> >> Signed-off-by: Ben Chan <[email protected] <mailto:[email protected]>>
> >
> > Your Signed-off-by doesn't match your From: line.
> >
> >> ---
> >> drivers/staging/skein/skein_generic.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> >> index 85bd7d0..899078f 100644
> >> --- a/drivers/staging/skein/skein_generic.c
> >> +++ b/drivers/staging/skein/skein_generic.c
> >> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
> >>
> >> return 0;
> >>
> >> -
> >> unreg512:
> >> crypto_unregister_shash(&alg512);
> >> unreg256:
> >> --
> >> 1.7.10.4
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to [email protected] <mailto:[email protected]>
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html <http://vger.kernel.org/majordomo-info.html>
> >> Please read the FAQ at http://www.tux.org/lkml/ <http://www.tux.org/lkml/>
> >
> > --
> > - Jeremiah Mahler
>
--
- Jeremiah Mahler
On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
> From: Kroderia <[email protected]>
>
> Delete a useless white space line according to the coding style.
>
> Signed-off-by: Ben Chan <[email protected]>
Sigh. Same problem :(
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..899078f 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
>
> return 0;
>
> -
> unreg512:
> crypto_unregister_shash(&alg512);
> unreg256:
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
Thanks for your tip. People say this is not a legal name, but I really use this for all my English profile. I create another name sound like my real name and it cause this "From" display. So sorry bothering you. I will really check it and send in the future.
> On Dec 24, 2014, at 12:00 AM, Dan Carpenter <[email protected]> wrote:
>
> On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
>> From: Kroderia <[email protected]>
>
> So very very close to being correct. Also I think someone may have
> already sent this one but it just hasn't been applied because the merge
> window is open. I've definitely seen this line before...
>
> regards,
> dan carpenter
>
I am not in English, French or else, means I don't have a English name. I uses the Email's name and people said it is illegal. And then I made up Ben Chan, which really sounds like my real name.
> On Dec 24, 2014, at 12:04 AM, Jeremiah Mahler <[email protected]> wrote:
>
> On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
>> People say that is not a legal name, therefore I create this English name sound like my real name.
>>
>
> I'm confused. So Ben Chan isn't your real name, just one you made up?
>
>>> On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler <[email protected]> wrote:
>>>
>>> On Tue, Dec 23, 2014 at 03:37:53PM +0000, Kroderia wrote:
>>>> Signed-off-by: Ben Chan <[email protected] <mailto:[email protected]>>
>>>
>>> Your Signed-off-by doesn't match your From: line.
>>>
>>>> ---
>>>> drivers/staging/skein/skein_generic.c | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
>>>> index 85bd7d0..899078f 100644
>>>> --- a/drivers/staging/skein/skein_generic.c
>>>> +++ b/drivers/staging/skein/skein_generic.c
>>>> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
>>>>
>>>> return 0;
>>>>
>>>> -
>>>> unreg512:
>>>> crypto_unregister_shash(&alg512);
>>>> unreg256:
>>>> --
>>>> 1.7.10.4
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to [email protected] <mailto:[email protected]>
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html <http://vger.kernel.org/majordomo-info.html>
>>>> Please read the FAQ at http://www.tux.org/lkml/ <http://www.tux.org/lkml/>
>>>
>>> --
>>> - Jeremiah Mahler
>>
>
> --
> - Jeremiah Mahler
On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote:
> Thanks for your tip. People say this is not a legal name, but I really
> use this for all my English profile. I create another name sound like
> my real name and it cause this "From" display. So sorry bothering you.
> I will really check it and send in the future.
What is wrong with using your legal name, there is no reason it has to
be "changed" into english at all.
greg k-h
I found no one using the words like Chinese, Japanese here.
> On Dec 24, 2014, at 12:14 AM, Greg KH <[email protected]> wrote:
>
> On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote:
>> Thanks for your tip. People say this is not a legal name, but I really
>> use this for all my English profile. I create another name sound like
>> my real name and it cause this "From" display. So sorry bothering you.
>> I will really check it and send in the future.
>
> What is wrong with using your legal name, there is no reason it has to
> be "changed" into english at all.
>
> greg k-h
On Wed, Dec 24, 2014 at 12:18:53AM +0800, Gmail wrote:
> I found no one using the words like Chinese, Japanese here.
Not true, feel free to do so, there is no reason not to.
greg k-h