2014-12-24 04:07:49

by Panir.Nyan

Subject: [PATCH 1/2] staging: speakup: Split the comment to fit the length

Split the comment to fit the length.

Signed-off-by: Panir Nyan <[email protected]>
---
drivers/staging/speakup/synth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index f3aa423..01eddab 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
* must be taken at each kernel->speakup transition and released at
* each corresponding speakup->kernel transition.
*
- * The progression thread only interferes with the speakup machinery through
- * the synth buffer, so only needs to take the lock while tinkering with
- * the buffer.
+ * The progression thread only interferes with the speakup machinery
+ * through the synth buffer, so only needs to take the lock
+ * while tinkering with the buffer.
*
* We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
* spinlock because speakup needs to disable the keyboard IRQ.
--
1.7.10.4

2014-12-24 04:07:56

by Panir.Nyan

Subject: [PATCH 2/2] staging: speakup: Combine the consecutive string

Combine the consecutive string

Signed-off-by: Panir Nyan <[email protected]>
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index b12c76d..3708bc1 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
if (ch >= ' ' && ch < '~')
*cp1++ = ch;
else
- cp1 += sprintf(cp1, "\\""x%02x", ch);
+ cp1 += sprintf(cp1, "\\x%02x", ch);
}
*cp1++ = '"';
*cp1++ = '\n';
--
1.7.10.4

2014-12-24 15:42:04

by Samuel Thibault

Subject: Re: [PATCH 1/2] staging: speakup: Split the comment to fit the length

Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +0000, a ?crit :
> Split the comment to fit the length.
>
> Signed-off-by: Panir Nyan <[email protected]>

Acked-by: Samuel Thibault <[email protected]>

> ---
> drivers/staging/speakup/synth.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index f3aa423..01eddab 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
> * must be taken at each kernel->speakup transition and released at
> * each corresponding speakup->kernel transition.
> *
> - * The progression thread only interferes with the speakup machinery through
> - * the synth buffer, so only needs to take the lock while tinkering with
> - * the buffer.
> + * The progression thread only interferes with the speakup machinery
> + * through the synth buffer, so only needs to take the lock
> + * while tinkering with the buffer.
> *
> * We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
> * spinlock because speakup needs to disable the keyboard IRQ.
> --
> 1.7.10.4
>

--
Samuel
Linux, c'est simple : ?a s'adresse ? une machine qui est parfois un peu
marabout?e mais qui d'habitude n'a pas d'?tats d'?me. Sur Usenet y'a
plein d'humains et de primates, et ?a devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une ?me ?" -+-

2014-12-24 15:44:28

by Samuel Thibault

Subject: Re: [PATCH 2/2] staging: speakup: Combine the consecutive string

Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +0000, a ?crit :
> Combine the consecutive string
>
> Signed-off-by: Panir Nyan <[email protected]>

Acked-by: Samuel Thibault <[email protected]>

> ---
> drivers/staging/speakup/kobjects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index b12c76d..3708bc1 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
> if (ch >= ' ' && ch < '~')
> *cp1++ = ch;
> else
> - cp1 += sprintf(cp1, "\\""x%02x", ch);
> + cp1 += sprintf(cp1, "\\x%02x", ch);
> }
> *cp1++ = '"';
> *cp1++ = '\n';
> --
> 1.7.10.4
>

--
Samuel
"...Unix, MS-DOS, and Windows NT (also known as the Good, the Bad, and
the Ugly)."
(By Matt Welsh)