2014-12-25 01:57:24

by David Decotigny

Subject: [PATCH v1] staging: comedi: dmm32at: fix style issues

Before:
1 ERROR: code indent should use tabs where possible
1 WARNING: please, no spaces at the start of a line

After:
(none)

Signed-off-by: David Decotigny <[email protected]>
---
drivers/staging/comedi/drivers/dmm32at.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..1615103 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
outb(hi2, dev->iobase + DMM32AT_CLK2);

/* enable the ai conversion interrupt and the clock to start scans */
- outb(DMM32AT_INTCLK_ADINT |
- DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
- dev->iobase + DMM32AT_INTCLK_REG);
+ outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN |
+ DMM32AT_INTCLK_CLKSEL,
+ dev->iobase + DMM32AT_INTCLK_REG);
}

static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
--
2.2.0.rc0.207.ga3a616c

2014-12-25 11:04:50

by Jeremiah Mahler

Subject: Re: [PATCH v1] staging: comedi: dmm32at: fix style issues

David,

On Wed, Dec 24, 2014 at 05:55:38PM -0800, David Decotigny wrote:
> Before:
> 1 ERROR: code indent should use tabs where possible
> 1 WARNING: please, no spaces at the start of a line
>
> After:
> (none)
>
> Signed-off-by: David Decotigny <[email protected]>
> ---
> drivers/staging/comedi/drivers/dmm32at.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..1615103 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
> outb(hi2, dev->iobase + DMM32AT_CLK2);
>
> /* enable the ai conversion interrupt and the clock to start scans */
> - outb(DMM32AT_INTCLK_ADINT |
> - DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> - dev->iobase + DMM32AT_INTCLK_REG);
> + outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN |
> + DMM32AT_INTCLK_CLKSEL,
> + dev->iobase + DMM32AT_INTCLK_REG);
> }
>
> static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

Your patch re-formats this section, but I don't think this is needed.
Some people like to format their code so it is aligned at the left
parenthesis.

The warning is about the line which is indented entirely using spaces
and no tabs. The following patch would fix the warning without
disrupting the formatting.

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..31919b8 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
/* enable the ai conversion interrupt and the clock to start scans */
outb(DMM32AT_INTCLK_ADINT |
DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
- dev->iobase + DMM32AT_INTCLK_REG);
+ dev->iobase + DMM32AT_INTCLK_REG);
}

static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

--
- Jeremiah Mahler