2014-12-30 18:19:13

by Alexander Kuleshov

Subject: [PATCH v3] x86/boot/early_serial_console: Remove unnecessary check

There is already the same check before.

Signed-off-by: Alexander Kuleshov <[email protected]>
---
arch/x86/boot/early_serial_console.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 5df2869..c23bcae 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -73,9 +73,8 @@ static void parse_earlyprintk(void)
} else if (!strncmp(arg + pos, "ttyS", 4)) {
static const int bases[] = { 0x3f8, 0x2f8 };
int idx = 0;
-
- if (!strncmp(arg + pos, "ttyS", 4))
- pos += 4;
+ /* += strlen("ttyS"); */
+ pos += 4;

if (arg[pos++] == '1')
idx = 1;
--
2.2.1.202.g44ae4ee.dirty

2014-12-30 21:36:16

by Borislav Petkov

Subject: Re: [PATCH v3] x86/boot/early_serial_console: Remove unnecessary check

On Wed, Dec 31, 2014 at 12:18:58AM +0600, Alexander Kuleshov wrote:
> There is already the same check before.
>
> Signed-off-by: Alexander Kuleshov <[email protected]>
> ---
> arch/x86/boot/early_serial_console.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> index 5df2869..c23bcae 100644
> --- a/arch/x86/boot/early_serial_console.c
> +++ b/arch/x86/boot/early_serial_console.c
> @@ -73,9 +73,8 @@ static void parse_earlyprintk(void)
> } else if (!strncmp(arg + pos, "ttyS", 4)) {
> static const int bases[] = { 0x3f8, 0x2f8 };
> int idx = 0;
> -

You've removed the newline here and we usually do leave an empty line
between the function local variables declarations and the rest of the
function for better readability.

And to answer your question from earlier: yes, if you want to send a
corrected patch, please do send it as a reply to this one.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--