2014-12-31 07:12:52

by Alexander Kuleshov

[permalink] [raw]
Subject: [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check

There is already the same check before.

Signed-off-by: Alexander Kuleshov <[email protected]>
---
arch/x86/boot/early_serial_console.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 5df2869..2b1c403 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -74,8 +74,8 @@ static void parse_earlyprintk(void)
static const int bases[] = { 0x3f8, 0x2f8 };
int idx = 0;

- if (!strncmp(arg + pos, "ttyS", 4))
- pos += 4;
+ /* += strlen("ttyS"); */
+ pos += 4;

if (arg[pos++] == '1')
idx = 1;
--
2.2.1.202.g44ae4ee.dirty


2014-12-31 13:58:01

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check

On Wed, Dec 31, 2014 at 01:12:38PM +0600, Alexander Kuleshov wrote:
> There is already the same check before.
>
> Signed-off-by: Alexander Kuleshov <[email protected]>

Acked-by: Borislav Petkov <[email protected]>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--