2014-12-31 09:32:33

by Serguey Parkhomovsky

Subject: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

Fixes the following sparse warnings:

drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol 'libcfs_arch_cleanup' was not declared. Should it be static?

Signed-off-by: Serguey Parkhomovsky <[email protected]>
---
v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h.
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++
drivers/staging/lustre/lustre/libcfs/module.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
index a6b2f90..4410d7f 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
@@ -85,6 +85,9 @@ static inline int __is_po2(unsigned long long val)

#include <linux/list.h>

+int libcfs_arch_init(void);
+void libcfs_arch_cleanup(void);
+
/* libcfs tcpip */
int libcfs_ipif_query(char *name, int *up, __u32 *ip, __u32 *mask);
int libcfs_ipif_enumerate(char ***names);
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
index 2c4fc74..31a4d19 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/drivers/staging/lustre/lustre/libcfs/module.c
@@ -334,8 +334,6 @@ extern struct mutex cfs_trace_thread_mutex;
extern struct cfs_wi_sched *cfs_sched_rehash;

extern void libcfs_init_nidstrings(void);
-extern int libcfs_arch_init(void);
-extern void libcfs_arch_cleanup(void);

static int init_libcfs_module(void)
{
--
1.9.3

2014-12-31 10:40:40

by Konrad Zapalowicz

Subject: Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On 12/31, Serguey Parkhomovsky wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static?
> drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol 'libcfs_arch_cleanup' was not declared. Should it be static?

This lines are way too long. You should break the commit message line
around 72nd column so that it looks nice when emailed.

You can also omit the filename from the topic line as this is already in
the diff.

Thanks,
Konrad

> Signed-off-by: Serguey Parkhomovsky <[email protected]>
> ---
> v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h.
> drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++
> drivers/staging/lustre/lustre/libcfs/module.c | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
> index a6b2f90..4410d7f 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
> @@ -85,6 +85,9 @@ static inline int __is_po2(unsigned long long val)
>
> #include <linux/list.h>
>
> +int libcfs_arch_init(void);
> +void libcfs_arch_cleanup(void);
> +
> /* libcfs tcpip */
> int libcfs_ipif_query(char *name, int *up, __u32 *ip, __u32 *mask);
> int libcfs_ipif_enumerate(char ***names);
> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
> index 2c4fc74..31a4d19 100644
> --- a/drivers/staging/lustre/lustre/libcfs/module.c
> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
> @@ -334,8 +334,6 @@ extern struct mutex cfs_trace_thread_mutex;
> extern struct cfs_wi_sched *cfs_sched_rehash;
>
> extern void libcfs_init_nidstrings(void);
> -extern int libcfs_arch_init(void);
> -extern void libcfs_arch_cleanup(void);
>
> static int init_libcfs_module(void)
> {
> --
> 1.9.3
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

2014-12-31 18:55:21

by Serguey Parkhomovsky

Subject: Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote:
> This lines are way too long. You should break the commit message line
> around 72nd column so that it looks nice when emailed.
>
> You can also omit the filename from the topic line as this is already in
> the diff.

Thanks for the feedback; I'll send an updated patch that fixes these issues.

Serguey