2014-10-22 11:24:50

by Masanari Iida

Subject: [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c

allow_kdump was enabled as default since following commit.

commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
watchdog: hpwdt: Unregister NMI events on exit.

But the initialization message was not modified.
So it still shows

HP Watchdog Timer Driver: NMI decoding initialized,
allow kernel dump: ON (default = 0/OFF) <=

This "default = 0/OFF" message may confuse users.
Fix it as "default = 1/ON".

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 75d2243..ada3e44 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -745,7 +745,7 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev)

dev_info(&dev->dev,
"HP Watchdog Timer Driver: NMI decoding initialized"
- ", allow kernel dump: %s (default = 0/OFF)\n",
+ ", allow kernel dump: %s (default = 1/ON)\n",
(allow_kdump == 0) ? "OFF" : "ON");
return 0;

--
2.1.2.451.g98349e5

2015-02-02 23:16:03

by Wim Van Sebroeck

Subject: Re: [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c

Hi Masanari,

> allow_kdump was enabled as default since following commit.
>
> commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
> watchdog: hpwdt: Unregister NMI events on exit.
>
> But the initialization message was not modified.
> So it still shows
>
> HP Watchdog Timer Driver: NMI decoding initialized,
> allow kernel dump: ON (default = 0/OFF) <=
>
> This "default = 0/OFF" message may confuse users.
> Fix it as "default = 1/ON".
>
> Signed-off-by: Masanari Iida <[email protected]>

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.