2015-02-05 14:58:06

by Prabhakar

[permalink] [raw]
Subject: [PATCH] classmate-laptop: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1) and applies on top linux-next.

drivers/platform/x86/classmate-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 70d355a..55cf10b 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -520,7 +520,7 @@ static acpi_status cmpc_get_accel(acpi_handle handle,
{
union acpi_object param[2];
struct acpi_object_list input;
- struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 0 };
+ struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
unsigned char *locs;
acpi_status status;

--
1.9.1


Subject: Re: [PATCH] classmate-laptop: fix sparse warning

On Thu, Feb 05, 2015 at 02:57:44PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Acked-by: Thadeu Lima de Souza Cascardo <[email protected]>

> ---
> Found this issue on linux-next (gcc version 4.9.2,
> sparse version 0.4.5-rc1) and applies on top linux-next.
>
> drivers/platform/x86/classmate-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 70d355a..55cf10b 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -520,7 +520,7 @@ static acpi_status cmpc_get_accel(acpi_handle handle,
> {
> union acpi_object param[2];
> struct acpi_object_list input;
> - struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 0 };
> + struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
> unsigned char *locs;
> acpi_status status;
>
> --
> 1.9.1
>

2015-02-07 20:12:32

by Darren Hart

[permalink] [raw]
Subject: Re: [PATCH] classmate-laptop: fix sparse warning

On Thu, Feb 05, 2015 at 02:57:44PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Queued, thanks Lad.

--
Darren Hart
Intel Open Source Technology Center