2015-02-08 22:29:16

by Luis de Bethencourt

[permalink] [raw]

Subject: [PATCH] media: bcm2048: remove unused return of function

---

Integer return of bcm2048_parse_rds_rt () is never used, changing the return
type to void.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 5382506..7f3d528 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -1579,7 +1579,7 @@ static void bcm2048_parse_rt_match_d(struct bcm2048_device *bdev, int i,
bcm2048_parse_rds_rt_block(bdev, i, index+2, crc);
}

-static int bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
+static void bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
{
int i, index = 0, crc, match_b = 0, match_c = 0, match_d = 0;

@@ -1615,8 +1615,6 @@ static int bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
match_b = 1;
}
}
-
- return 0;
}

static void bcm2048_parse_rds_ps_block(struct bcm2048_device *bdev, int i,
--
2.1.0

2015-02-09 09:17:11

by Pali Rohár

[permalink] [raw]

Subject: Re: [PATCH] media: bcm2048: remove unused return of function

---

On Sunday 08 February 2015 23:29:11 Luis de Bethencourt wrote:
> Integer return of bcm2048_parse_rds_rt () is never used,
> changing the return type to void.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Looks good,

Acked-by: Pali Rohár <[email protected]>

--
Pali Rohár
[email protected]

---

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part.