2015-02-03 14:34:58

by David Hildenbrand

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

>
> * Paul E. McKenney <[email protected]> wrote:
>
> > Hello, Ingo,
> >
> > The changes in this series include:
> >
> > 1. Documentation updates. These were posted to LKML at
> > https://lkml.org/lkml/2015/1/7/496.
> >
> > 2. Miscellaneous fixes. These were posted to LKML at
> > https://lkml.org/lkml/2015/1/7/507.
> >
> > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > interaction of RCU priority boosting and CPU hotplug. These were
> > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> >
> > 4. SRCU updates. These were posted to LKML at
> > https://lkml.org/lkml/2015/1/7/555.
> >
> > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > https://lkml.org/lkml/2015/1/7/565.
> >
> > 6. RCU torture-test updates. These were posted to LKML at
> > https://lkml.org/lkml/2015/1/7/591.
> >
> > These changes are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> >
> > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> >
> > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> >
> > ----------------------------------------------------------------
> >
> > Alexander Gordeev (1):
> > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> >
> > Calvin Owens (1):
> > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> >
> > David Hildenbrand (1):
> > hotplugcpu: Avoid deadlocks by waking active_writer
> >

Hi Ingo, Paul,

Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
active_writer addresses) in 3.18-rc3.

And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
probably (have done a) cc-stable.

David


2015-02-03 16:39:06

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> >
> > * Paul E. McKenney <[email protected]> wrote:
> >
> > > Hello, Ingo,
> > >
> > > The changes in this series include:
> > >
> > > 1. Documentation updates. These were posted to LKML at
> > > https://lkml.org/lkml/2015/1/7/496.
> > >
> > > 2. Miscellaneous fixes. These were posted to LKML at
> > > https://lkml.org/lkml/2015/1/7/507.
> > >
> > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > interaction of RCU priority boosting and CPU hotplug. These were
> > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > >
> > > 4. SRCU updates. These were posted to LKML at
> > > https://lkml.org/lkml/2015/1/7/555.
> > >
> > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > https://lkml.org/lkml/2015/1/7/565.
> > >
> > > 6. RCU torture-test updates. These were posted to LKML at
> > > https://lkml.org/lkml/2015/1/7/591.
> > >
> > > These changes are available in the git repository at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > >
> > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > >
> > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > >
> > > ----------------------------------------------------------------
> > >
> > > Alexander Gordeev (1):
> > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > >
> > > Calvin Owens (1):
> > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > >
> > > David Hildenbrand (1):
> > > hotplugcpu: Avoid deadlocks by waking active_writer
> > >
>
> Hi Ingo, Paul,
>
> Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> active_writer addresses) in 3.18-rc3.
>
> And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> probably (have done a) cc-stable.

Good point, though appropriate RCU changes seem to make their way to -stable
without explicit CCs. Maybe I should be doing them, but doing so in the
past has normally gotten me complaints from the -stable maintainers.

Ingo, how would you like me to be handling this in the future?

Thanx, Paul

2015-02-06 18:28:29

by Ingo Molnar

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20


* Paul E. McKenney <[email protected]> wrote:

> On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > >
> > > * Paul E. McKenney <[email protected]> wrote:
> > >
> > > > Hello, Ingo,
> > > >
> > > > The changes in this series include:
> > > >
> > > > 1. Documentation updates. These were posted to LKML at
> > > > https://lkml.org/lkml/2015/1/7/496.
> > > >
> > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > https://lkml.org/lkml/2015/1/7/507.
> > > >
> > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > >
> > > > 4. SRCU updates. These were posted to LKML at
> > > > https://lkml.org/lkml/2015/1/7/555.
> > > >
> > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > https://lkml.org/lkml/2015/1/7/565.
> > > >
> > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > https://lkml.org/lkml/2015/1/7/591.
> > > >
> > > > These changes are available in the git repository at:
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > >
> > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > >
> > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > >
> > > > ----------------------------------------------------------------
> > > >
> > > > Alexander Gordeev (1):
> > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > >
> > > > Calvin Owens (1):
> > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > >
> > > > David Hildenbrand (1):
> > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > >
> >
> > Hi Ingo, Paul,
> >
> > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > active_writer addresses) in 3.18-rc3.
> >
> > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > probably (have done a) cc-stable.
>
> Good point, though appropriate RCU changes seem to make their
> way to -stable without explicit CCs. Maybe I should be doing
> them, but doing so in the past has normally gotten me
> complaints from the -stable maintainers.
>
> Ingo, how would you like me to be handling this in the future?

So if you put a Cc: stable tag into the commit then usually they
get picked up automatically.

Just make sure you don't Cc: the stable team on patch submissions
(which might or might not make it into Linus's tree), that's what
will get complaints.

Does that work for you?

Thanks,

Ingo

2015-02-06 18:56:53

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

On Fri, Feb 06, 2015 at 07:28:23PM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <[email protected]> wrote:
>
> > On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > > >
> > > > * Paul E. McKenney <[email protected]> wrote:
> > > >
> > > > > Hello, Ingo,
> > > > >
> > > > > The changes in this series include:
> > > > >
> > > > > 1. Documentation updates. These were posted to LKML at
> > > > > https://lkml.org/lkml/2015/1/7/496.
> > > > >
> > > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > > https://lkml.org/lkml/2015/1/7/507.
> > > > >
> > > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > > >
> > > > > 4. SRCU updates. These were posted to LKML at
> > > > > https://lkml.org/lkml/2015/1/7/555.
> > > > >
> > > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > > https://lkml.org/lkml/2015/1/7/565.
> > > > >
> > > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > > https://lkml.org/lkml/2015/1/7/591.
> > > > >
> > > > > These changes are available in the git repository at:
> > > > >
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > > >
> > > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > > >
> > > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > > >
> > > > > ----------------------------------------------------------------
> > > > >
> > > > > Alexander Gordeev (1):
> > > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > > >
> > > > > Calvin Owens (1):
> > > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > > >
> > > > > David Hildenbrand (1):
> > > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > > >
> > >
> > > Hi Ingo, Paul,
> > >
> > > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > > active_writer addresses) in 3.18-rc3.
> > >
> > > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > > probably (have done a) cc-stable.
> >
> > Good point, though appropriate RCU changes seem to make their
> > way to -stable without explicit CCs. Maybe I should be doing
> > them, but doing so in the past has normally gotten me
> > complaints from the -stable maintainers.
> >
> > Ingo, how would you like me to be handling this in the future?
>
> So if you put a Cc: stable tag into the commit then usually they
> get picked up automatically.
>
> Just make sure you don't Cc: the stable team on patch submissions
> (which might or might not make it into Linus's tree), that's what
> will get complaints.
>
> Does that work for you?

I will give it a spin. I thought that adding the "Cc: stable" tag to
the commit log got me complaints when I later did git-format-patch and
git-send-email, but perhaps I was confused or this has since changed.

Thanx, Paul

2015-02-09 07:56:17

by Ingo Molnar

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20


* Paul E. McKenney <[email protected]> wrote:

> On Fri, Feb 06, 2015 at 07:28:23PM +0100, Ingo Molnar wrote:
> >
> > * Paul E. McKenney <[email protected]> wrote:
> >
> > > On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > > > >
> > > > > * Paul E. McKenney <[email protected]> wrote:
> > > > >
> > > > > > Hello, Ingo,
> > > > > >
> > > > > > The changes in this series include:
> > > > > >
> > > > > > 1. Documentation updates. These were posted to LKML at
> > > > > > https://lkml.org/lkml/2015/1/7/496.
> > > > > >
> > > > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > > > https://lkml.org/lkml/2015/1/7/507.
> > > > > >
> > > > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > > > >
> > > > > > 4. SRCU updates. These were posted to LKML at
> > > > > > https://lkml.org/lkml/2015/1/7/555.
> > > > > >
> > > > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > > > https://lkml.org/lkml/2015/1/7/565.
> > > > > >
> > > > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > > > https://lkml.org/lkml/2015/1/7/591.
> > > > > >
> > > > > > These changes are available in the git repository at:
> > > > > >
> > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > > > >
> > > > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > > > >
> > > > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > > > >
> > > > > > ----------------------------------------------------------------
> > > > > >
> > > > > > Alexander Gordeev (1):
> > > > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > > > >
> > > > > > Calvin Owens (1):
> > > > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > > > >
> > > > > > David Hildenbrand (1):
> > > > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > > > >
> > > >
> > > > Hi Ingo, Paul,
> > > >
> > > > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > > > active_writer addresses) in 3.18-rc3.
> > > >
> > > > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > > > probably (have done a) cc-stable.
> > >
> > > Good point, though appropriate RCU changes seem to make their
> > > way to -stable without explicit CCs. Maybe I should be doing
> > > them, but doing so in the past has normally gotten me
> > > complaints from the -stable maintainers.
> > >
> > > Ingo, how would you like me to be handling this in the future?
> >
> > So if you put a Cc: stable tag into the commit then usually they
> > get picked up automatically.
> >
> > Just make sure you don't Cc: the stable team on patch
> > submissions (which might or might not make it into
> > Linus's tree), that's what will get complaints.
> >
> > Does that work for you?
>
> I will give it a spin. I thought that adding the "Cc:
> stable" tag to the commit log got me complaints when I
> later did git-format-patch and git-send-email, but
> perhaps I was confused or this has since changed.

Yeah, I believe that will get you complaints, so you have
to avoid sending those emails to -stable - but there's no
restriction on what can be in the Cc: entries of the commit
log itself.

Thanks,

Ingo

2015-02-09 13:50:53

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

On Mon, Feb 09, 2015 at 08:56:10AM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <[email protected]> wrote:
>
> > On Fri, Feb 06, 2015 at 07:28:23PM +0100, Ingo Molnar wrote:
> > >
> > > * Paul E. McKenney <[email protected]> wrote:
> > >
> > > > On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > > > > >
> > > > > > * Paul E. McKenney <[email protected]> wrote:
> > > > > >
> > > > > > > Hello, Ingo,
> > > > > > >
> > > > > > > The changes in this series include:
> > > > > > >
> > > > > > > 1. Documentation updates. These were posted to LKML at
> > > > > > > https://lkml.org/lkml/2015/1/7/496.
> > > > > > >
> > > > > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > > > > https://lkml.org/lkml/2015/1/7/507.
> > > > > > >
> > > > > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > > > > >
> > > > > > > 4. SRCU updates. These were posted to LKML at
> > > > > > > https://lkml.org/lkml/2015/1/7/555.
> > > > > > >
> > > > > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > > > > https://lkml.org/lkml/2015/1/7/565.
> > > > > > >
> > > > > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > > > > https://lkml.org/lkml/2015/1/7/591.
> > > > > > >
> > > > > > > These changes are available in the git repository at:
> > > > > > >
> > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > > > > >
> > > > > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > > > > >
> > > > > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > > > > >
> > > > > > > ----------------------------------------------------------------
> > > > > > >
> > > > > > > Alexander Gordeev (1):
> > > > > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > > > > >
> > > > > > > Calvin Owens (1):
> > > > > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > > > > >
> > > > > > > David Hildenbrand (1):
> > > > > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > > > > >
> > > > >
> > > > > Hi Ingo, Paul,
> > > > >
> > > > > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > > > > active_writer addresses) in 3.18-rc3.
> > > > >
> > > > > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > > > > probably (have done a) cc-stable.
> > > >
> > > > Good point, though appropriate RCU changes seem to make their
> > > > way to -stable without explicit CCs. Maybe I should be doing
> > > > them, but doing so in the past has normally gotten me
> > > > complaints from the -stable maintainers.
> > > >
> > > > Ingo, how would you like me to be handling this in the future?
> > >
> > > So if you put a Cc: stable tag into the commit then usually they
> > > get picked up automatically.
> > >
> > > Just make sure you don't Cc: the stable team on patch
> > > submissions (which might or might not make it into
> > > Linus's tree), that's what will get complaints.
> > >
> > > Does that work for you?
> >
> > I will give it a spin. I thought that adding the "Cc:
> > stable" tag to the commit log got me complaints when I
> > later did git-format-patch and git-send-email, but
> > perhaps I was confused or this has since changed.
>
> Yeah, I believe that will get you complaints, so you have
> to avoid sending those emails to -stable - but there's no
> restriction on what can be in the Cc: entries of the commit
> log itself.

OK, so if I understand correctly, I need to add the Cc: stable
tags after the last git-format-patch/git-send-email, but (of
course) before the git-request-pull. Is that the trick?

Thanx, Paul

2015-02-09 17:45:42

by Ingo Molnar

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20


* Paul E. McKenney <[email protected]> wrote:

> On Mon, Feb 09, 2015 at 08:56:10AM +0100, Ingo Molnar wrote:
> >
> > * Paul E. McKenney <[email protected]> wrote:
> >
> > > On Fri, Feb 06, 2015 at 07:28:23PM +0100, Ingo Molnar wrote:
> > > >
> > > > * Paul E. McKenney <[email protected]> wrote:
> > > >
> > > > > On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > > > > > >
> > > > > > > * Paul E. McKenney <[email protected]> wrote:
> > > > > > >
> > > > > > > > Hello, Ingo,
> > > > > > > >
> > > > > > > > The changes in this series include:
> > > > > > > >
> > > > > > > > 1. Documentation updates. These were posted to LKML at
> > > > > > > > https://lkml.org/lkml/2015/1/7/496.
> > > > > > > >
> > > > > > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > > > > > https://lkml.org/lkml/2015/1/7/507.
> > > > > > > >
> > > > > > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > > > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > > > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > > > > > >
> > > > > > > > 4. SRCU updates. These were posted to LKML at
> > > > > > > > https://lkml.org/lkml/2015/1/7/555.
> > > > > > > >
> > > > > > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > > > > > https://lkml.org/lkml/2015/1/7/565.
> > > > > > > >
> > > > > > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > > > > > https://lkml.org/lkml/2015/1/7/591.
> > > > > > > >
> > > > > > > > These changes are available in the git repository at:
> > > > > > > >
> > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > > > > > >
> > > > > > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > > > > > >
> > > > > > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > > > > > >
> > > > > > > > ----------------------------------------------------------------
> > > > > > > >
> > > > > > > > Alexander Gordeev (1):
> > > > > > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > > > > > >
> > > > > > > > Calvin Owens (1):
> > > > > > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > > > > > >
> > > > > > > > David Hildenbrand (1):
> > > > > > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > > > > > >
> > > > > >
> > > > > > Hi Ingo, Paul,
> > > > > >
> > > > > > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > > > > > active_writer addresses) in 3.18-rc3.
> > > > > >
> > > > > > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > > > > > probably (have done a) cc-stable.
> > > > >
> > > > > Good point, though appropriate RCU changes seem to make their
> > > > > way to -stable without explicit CCs. Maybe I should be doing
> > > > > them, but doing so in the past has normally gotten me
> > > > > complaints from the -stable maintainers.
> > > > >
> > > > > Ingo, how would you like me to be handling this in the future?
> > > >
> > > > So if you put a Cc: stable tag into the commit then usually they
> > > > get picked up automatically.
> > > >
> > > > Just make sure you don't Cc: the stable team on patch
> > > > submissions (which might or might not make it into
> > > > Linus's tree), that's what will get complaints.
> > > >
> > > > Does that work for you?
> > >
> > > I will give it a spin. I thought that adding the "Cc:
> > > stable" tag to the commit log got me complaints when I
> > > later did git-format-patch and git-send-email, but
> > > perhaps I was confused or this has since changed.
> >
> > Yeah, I believe that will get you complaints, so you have
> > to avoid sending those emails to -stable - but there's no
> > restriction on what can be in the Cc: entries of the commit
> > log itself.
>
> OK, so if I understand correctly, I need to add the Cc:
> stable tags after the last
> git-format-patch/git-send-email, but (of course) before
> the git-request-pull. Is that the trick?

So I'd try to avoid the unnecessary rebase: teach
git-send-email to not Cc: to -stable, even though it's in
the Cc: list? Not sure how that's done though.

Thanks,

Ingo

2015-02-09 19:43:11

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

On Mon, Feb 09, 2015 at 06:45:36PM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <[email protected]> wrote:
>
> > On Mon, Feb 09, 2015 at 08:56:10AM +0100, Ingo Molnar wrote:
> > >
> > > * Paul E. McKenney <[email protected]> wrote:
> > >
> > > > On Fri, Feb 06, 2015 at 07:28:23PM +0100, Ingo Molnar wrote:
> > > > >
> > > > > * Paul E. McKenney <[email protected]> wrote:
> > > > >
> > > > > > On Tue, Feb 03, 2015 at 03:34:45PM +0100, David Hildenbrand wrote:
> > > > > > > >
> > > > > > > > * Paul E. McKenney <[email protected]> wrote:
> > > > > > > >
> > > > > > > > > Hello, Ingo,
> > > > > > > > >
> > > > > > > > > The changes in this series include:
> > > > > > > > >
> > > > > > > > > 1. Documentation updates. These were posted to LKML at
> > > > > > > > > https://lkml.org/lkml/2015/1/7/496.
> > > > > > > > >
> > > > > > > > > 2. Miscellaneous fixes. These were posted to LKML at
> > > > > > > > > https://lkml.org/lkml/2015/1/7/507.
> > > > > > > > >
> > > > > > > > > 3. Preemptible-RCU fixes, including fixing an old bug in the
> > > > > > > > > interaction of RCU priority boosting and CPU hotplug. These were
> > > > > > > > > posted to LKML at https://lkml.org/lkml/2015/1/7/535.
> > > > > > > > >
> > > > > > > > > 4. SRCU updates. These were posted to LKML at
> > > > > > > > > https://lkml.org/lkml/2015/1/7/555.
> > > > > > > > >
> > > > > > > > > 5. RCU CPU stall-warning updates. These were posted to LKML at
> > > > > > > > > https://lkml.org/lkml/2015/1/7/565.
> > > > > > > > >
> > > > > > > > > 6. RCU torture-test updates. These were posted to LKML at
> > > > > > > > > https://lkml.org/lkml/2015/1/7/591.
> > > > > > > > >
> > > > > > > > > These changes are available in the git repository at:
> > > > > > > > >
> > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
> > > > > > > > >
> > > > > > > > > for you to fetch changes up to 78e691f4ae2d5edea0199ca802bb505b9cdced88:
> > > > > > > > >
> > > > > > > > > Merge branches 'doc.2015.01.07a', 'fixes.2015.01.15a', 'preempt.2015.01.06a', 'srcu.2015.01.06a', 'stall.2015.01.16a' and 'torture.2015.01.11a' into HEAD (2015-01-15 23:34:34 -0800)
> > > > > > > > >
> > > > > > > > > ----------------------------------------------------------------
> > > > > > > > >
> > > > > > > > > Alexander Gordeev (1):
> > > > > > > > > rcu: Remove redundant rcu_is_cpu_rrupt_from_idle() from tiny RCU
> > > > > > > > >
> > > > > > > > > Calvin Owens (1):
> > > > > > > > > ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
> > > > > > > > >
> > > > > > > > > David Hildenbrand (1):
> > > > > > > > > hotplugcpu: Avoid deadlocks by waking active_writer
> > > > > > > > >
> > > > > > >
> > > > > > > Hi Ingo, Paul,
> > > > > > >
> > > > > > > Heiko/Christian seem to have hit the bug (hotplugcpu: Avoid deadlocks by waking
> > > > > > > active_writer addresses) in 3.18-rc3.
> > > > > > >
> > > > > > > And as commit b2c4623dcd07 was in linux starting with 3.18-rc3, we should
> > > > > > > probably (have done a) cc-stable.
> > > > > >
> > > > > > Good point, though appropriate RCU changes seem to make their
> > > > > > way to -stable without explicit CCs. Maybe I should be doing
> > > > > > them, but doing so in the past has normally gotten me
> > > > > > complaints from the -stable maintainers.
> > > > > >
> > > > > > Ingo, how would you like me to be handling this in the future?
> > > > >
> > > > > So if you put a Cc: stable tag into the commit then usually they
> > > > > get picked up automatically.
> > > > >
> > > > > Just make sure you don't Cc: the stable team on patch
> > > > > submissions (which might or might not make it into
> > > > > Linus's tree), that's what will get complaints.
> > > > >
> > > > > Does that work for you?
> > > >
> > > > I will give it a spin. I thought that adding the "Cc:
> > > > stable" tag to the commit log got me complaints when I
> > > > later did git-format-patch and git-send-email, but
> > > > perhaps I was confused or this has since changed.
> > >
> > > Yeah, I believe that will get you complaints, so you have
> > > to avoid sending those emails to -stable - but there's no
> > > restriction on what can be in the Cc: entries of the commit
> > > log itself.
> >
> > OK, so if I understand correctly, I need to add the Cc:
> > stable tags after the last
> > git-format-patch/git-send-email, but (of course) before
> > the git-request-pull. Is that the trick?
>
> So I'd try to avoid the unnecessary rebase: teach
> git-send-email to not Cc: to -stable, even though it's in
> the Cc: list? Not sure how that's done though.

I couldn't find anything in the documentation, so I sent an email to
[email protected] pleading for help. ;-)

Thanx, Paul

2015-02-10 08:19:56

by David Hildenbrand

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

> > OK, so if I understand correctly, I need to add the Cc:
> > stable tags after the last
> > git-format-patch/git-send-email, but (of course) before
> > the git-request-pull. Is that the trick?
>
> So I'd try to avoid the unnecessary rebase: teach
> git-send-email to not Cc: to -stable, even though it's in
> the Cc: list? Not sure how that's done though.
>

[email protected] ?

or as an alternative

--suppress-cc=bodycc

Maybe that's what you're looking for.

David

2015-02-10 18:34:50

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.20

On Tue, Feb 10, 2015 at 09:19:48AM +0100, David Hildenbrand wrote:
> > > OK, so if I understand correctly, I need to add the Cc:
> > > stable tags after the last
> > > git-format-patch/git-send-email, but (of course) before
> > > the git-request-pull. Is that the trick?
> >
> > So I'd try to avoid the unnecessary rebase: teach
> > git-send-email to not Cc: to -stable, even though it's in
> > the Cc: list? Not sure how that's done though.
> >
>
> [email protected] ?
>
> or as an alternative
>
> --suppress-cc=bodycc
>
> Maybe that's what you're looking for.

It wasn't obvious from the documentation that placing the email address
in "[email protected]" would work. However, Greg KH
says that it is OK to Cc stable -- apparently the gripe-mail I got some
time back when doing this was an anomaly.

Thanx, Paul