2015-02-13 15:36:36

by Boris Brezillon

Subject: [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe

Remove a useless pm_runtime_put_sync leading to unbalanced
usage_count.

Signed-off-by: Boris Brezillon <[email protected]>
Reported-by: Sylvain Rochet <[email protected]>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index 7320a6c..c1cb174 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -311,8 +311,6 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev)

pm_runtime_enable(dev->dev);

- pm_runtime_put_sync(dev->dev);
-
ret = atmel_hlcdc_dc_modeset_init(dev);
if (ret < 0) {
dev_err(dev->dev, "failed to initialize mode setting\n");
--
1.9.1

2015-02-13 16:05:27

by Sylvain Rochet

Subject: Re: [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe

Hello Boris,

On Fri, Feb 13, 2015 at 04:36:25PM +0100, Boris Brezillon wrote:
> Remove a useless pm_runtime_put_sync leading to unbalanced
> usage_count.
>
> Signed-off-by: Boris Brezillon <[email protected]>
> Reported-by: Sylvain Rochet <[email protected]>
> ---

Indeed, this is actually a necessary fix for my "drm: atmel-hlcdc: PM
support" series.

Tested-by: Sylvain Rochet <[email protected]>
Reviewed-by: Sylvain Rochet <[email protected]>

Sylvain