2015-02-16 01:09:41

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the slave-dma tree

Hi Vinod,

After merging the slave-dma tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/dma/imx-sdma.c: In function 'sdma_run_channel0':
drivers/dma/imx-sdma.c:535:57: error: macro "readl" passed 2 arguments, but takes just 1
if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
^
drivers/dma/imx-sdma.c:535:6: error: 'readl' undeclared (first use in this function)
if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
^

Caused by commit 66a073b6478d ("dmaengine: imx-sdma: switch to dynamic
context mode after script loaded").

I have used the slave-dma tree from next-20150213 for today.
--
Cheers,
Stephen Rothwell [email protected]

Attachments:
(No filename) (819.00 B)
OpenPGP digital signature

2015-02-16 01:49:00

by Yibin Gong

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the slave-dma tree

Hi Stephen,
Thanks for you report. I have notice it and sent the v4 patch review yesterday.

?????ҵ? iPhone

> ?? 2015??2??16?գ?09:09??Stephen Rothwell <[email protected]> д????
>
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
>
> drivers/dma/imx-sdma.c: In function 'sdma_run_channel0':
> drivers/dma/imx-sdma.c:535:57: error: macro "readl" passed 2 arguments, but takes just 1
> if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
> ^
> drivers/dma/imx-sdma.c:535:6: error: 'readl' undeclared (first use in this function)
> if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
> ^
>
> Caused by commit 66a073b6478d ("dmaengine: imx-sdma: switch to dynamic
> context mode after script loaded").
>
> I have used the slave-dma tree from next-20150213 for today.
> --
> Cheers,
> Stephen Rothwell [email protected]
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?

2015-02-16 04:09:16

by Vinod Koul

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the slave-dma tree

On Mon, Feb 16, 2015 at 01:48:56AM +0000, Yibin Gong wrote:
> Hi Stephen,
> Thanks for you report. I have notice it and sent the v4 patch review yesterday.
>
> 发自我的 iPhone
>
> > 在 2015年2月16日，09:09，Stephen Rothwell <[email protected]> 写道：
> >
> > Hi Vinod,
> >
> > After merging the slave-dma tree, today's linux-next build (arm multi_v7_defconfig)
> > failed like this:
> >
> > drivers/dma/imx-sdma.c: In function 'sdma_run_channel0':
> > drivers/dma/imx-sdma.c:535:57: error: macro "readl" passed 2 arguments, but takes just 1
> > if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
> > ^
> > drivers/dma/imx-sdma.c:535:6: error: 'readl' undeclared (first use in this function)
> > if (readl(SDMA_H_CONFIG_CSM, sdma->regs + SDMA_H_CONFIG) == 0)
> > ^
Thanks Stephen,

> >
> > Caused by commit 66a073b6478d ("dmaengine: imx-sdma: switch to dynamic
> > context mode after script loaded").
I have dropped the offending commit now

--
~Vinod

> >
> > I have used the slave-dma tree from next-20150213 for today.
> > --
> > Cheers,
> > Stephen Rothwell [email protected]

--