2014-12-08 22:22:37

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

drivers/clk/qcom/kpss-xcc.c:89:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Stephen Boyd <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

kpss-xcc.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/clk/qcom/kpss-xcc.c
+++ b/drivers/clk/qcom/kpss-xcc.c
@@ -86,7 +86,6 @@ static struct platform_driver kpss_xcc_d
.driver = {
.name = "kpss-xcc",
.of_match_table = kpss_xcc_match_table,
- .owner = THIS_MODULE,
},
};
module_platform_driver(kpss_xcc_driver);


2015-02-25 20:03:00

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

Quoting Stephen Boyd (2015-01-28 12:51:05)
> On 01/27/15 23:11, kbuild test robot wrote:
> > drivers/clk/qcom/lcc-msm8960.c:577:3-8: No need to set .owner here. The core will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: Stephen Boyd <[email protected]>
> > Signed-off-by: Fengguang Wu <[email protected]>
> > ---
>
> Reviewed-by: Stephen Boyd <[email protected]>

Applied.

Regards,
Mike

>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

2015-02-25 20:03:20

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

Quoting Stephen Boyd (2015-01-28 12:49:32)
> On 01/27/15 23:00, kbuild test robot wrote:
> > drivers/clk/qcom/lcc-ipq806x.c:465:3-8: No need to set .owner here. The core will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: Rajendra Nayak <[email protected]>
> > Signed-off-by: Fengguang Wu <[email protected]>
>
> Reviewed-by: Stephen Boyd <[email protected]>

Applied.

Regards,
Mike

>
> Thanks. This code was reposted from a time when this wasn't done
> automatically.
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>