2015-02-09 17:25:28

by Nicholas Mc Guire

[permalink] [raw]
Subject: [PATCH 1/2] ab8500_fg: match return type of wait_for_completion_timeout

return type of wait_for_completion_timeout is unsigned long not int. as
timeout is used for wait_for_completion_timeout exclusively here its
type is simply changed to unsigned long.

Signed-off-by: Nicholas Mc Guire <[email protected]>
---

Patch was only compile tested with u8500_defconfig + CONFIG_AB8500_BM=y

Patch is against 3.19.0-rc7 (localversion-next is -next-20150209)

drivers/power/ab8500_fg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index c908658..eee4493 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -622,7 +622,7 @@ int ab8500_fg_inst_curr_finalize(struct ab8500_fg *di, int *res)
u8 low, high;
int val;
int ret;
- int timeout;
+ unsigned long timeout;

if (!completion_done(&di->ab8500_fg_complete)) {
timeout = wait_for_completion_timeout(
@@ -716,7 +716,7 @@ fail:
int ab8500_fg_inst_curr_blocking(struct ab8500_fg *di)
{
int ret;
- int timeout;
+ unsigned long timeout;
int res = 0;

ret = ab8500_fg_inst_curr_start(di);
--
1.7.10.4


2015-02-25 21:48:06

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH 1/2] ab8500_fg: match return type of wait_for_completion_timeout

Hi,

On Mon, Feb 09, 2015 at 12:20:45PM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. as
> timeout is used for wait_for_completion_timeout exclusively here its
> type is simply changed to unsigned long.

thanks, applied to battery-2.6.git.

-- Sebastian


Attachments:
(No filename) (311.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments