2015-04-01 12:04:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] selftests: Change memory on-off-test.sh name to be unique

On Tue, Mar 31, 2015 at 06:10:59PM -0600, Shuah Khan wrote:
> cpu and memory hotplug scripts use the same name. Change
> memory on-off-test.sh to mem-on-off-test.sh.
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> tools/testing/selftests/memory-hotplug/Makefile | 6 +-
> .../selftests/memory-hotplug/mem-on-off-test.sh | 238 +++++++++++++++++++++
> .../selftests/memory-hotplug/on-off-test.sh | 238 ---------------------
> 3 files changed, 241 insertions(+), 241 deletions(-)
> create mode 100755 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> delete mode 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh

Hint, when making patches that rename files, use '-M' as a git diff
output, it will show the move much easier than adding and removing the
file.

Anyway, I have no problem with this:

Acked-by: Greg Kroah-Hartman <[email protected]>


2015-04-01 13:06:29

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] selftests: Change memory on-off-test.sh name to be unique

On 04/01/2015 06:04 AM, Greg KH wrote:
> On Tue, Mar 31, 2015 at 06:10:59PM -0600, Shuah Khan wrote:
>> cpu and memory hotplug scripts use the same name. Change
>> memory on-off-test.sh to mem-on-off-test.sh.
>>
>> Signed-off-by: Shuah Khan <[email protected]>
>> ---
>> tools/testing/selftests/memory-hotplug/Makefile | 6 +-
>> .../selftests/memory-hotplug/mem-on-off-test.sh | 238 +++++++++++++++++++++
>> .../selftests/memory-hotplug/on-off-test.sh | 238 ---------------------
>> 3 files changed, 241 insertions(+), 241 deletions(-)
>> create mode 100755 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
>> delete mode 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
>
> Hint, when making patches that rename files, use '-M' as a git diff
> output, it will show the move much easier than adding and removing the
> file.

Thanks for the tip. That would have made it easier to review.

>
> Anyway, I have no problem with this:
>
> Acked-by: Greg Kroah-Hartman <[email protected]>
>

thanks,
-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978