2015-04-05 01:41:55

by Amitoj Kaur Chawla

Subject: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

Removes extra parentheses around bitwise right shift operation.

The issue was detected using the following coccinelle script.
@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);


Signed-off-by: Amitoj Kaur Chawla <[email protected]>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 4074375..626b841 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -737,7 +737,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_secondary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
@@ -751,7 +751,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_primary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
--
1.9.1

2015-04-06 09:18:58

by Sudip Mukherjee

Subject: Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

On Sun, Apr 05, 2015 at 07:11:47AM +0530, Amitoj Kaur Chawla wrote:
> Removes extra parentheses around bitwise right shift operation.
this is not applying. please work against staging-testing.

regards
sudip
>

2015-04-07 08:01:26

by Dan Carpenter

Subject: Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

Some people like to put parenthesis around stuff. It's harmless here.

regards,
dan carpenter