2015-04-13 04:02:23

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC

Quoting Krzysztof Kozlowski (2015-03-28 09:37:05)
> 2015-03-27 17:27 GMT+01:00 Bartlomiej Zolnierkiewicz <[email protected]>:
> > Commit 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK
> > down feature") enabled ARMCLK down feature on all Exynos4
> > SoCs. Unfortunately on Exynos4210 SoC ARMCLK down feature
> > causes a lockup when ondemand cpufreq governor is used.
> > Fix it by limiting ARMCLK down feature to Exynos4x12 SoCs.
> >
> > This patch was tested on:
> > - Exynos4210 SoC based Trats board
> > - Exynos4210 SoC based Origen board
> > - Exynos4412 SoC based Trats2 board
> > - Exynos4412 SoC based Odroid-U3 board
> >
> > Cc: Krzysztof Kozlowski <[email protected]>
> > Cc: Daniel Drake <[email protected]>
> > Cc: Tomasz Figa <[email protected]>
> > Cc: Kukjin Kim <[email protected]>
> > Fixes: 42773b28e71d ("clk: samsung: exynos4: Enable ARMCLK down feature")
> > Cc: <[email protected]> # v3.17+
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> > ---
> > drivers/clk/samsung/clk-exynos4.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Applied.

Thanks,
Mike

>
> Best regards,
> Krzysztof