2015-04-02 06:40:46

by Chanwoo Choi

Subject: [PATCH] clk: Show clock rate instead of return value

This patch shows the current clock rate instead of return value
when clk_set_rate() return fail because log message means the clock rate.

Cc: Mike Turquette <[email protected]>
Cc: Stephen Boyd <[email protected]>
Signed-off-by: Chanwoo Choi <[email protected]>
---
drivers/clk/clk-conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
index aad4796..fb1ee65 100644
--- a/drivers/clk/clk-conf.c
+++ b/drivers/clk/clk-conf.c
@@ -107,8 +107,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)

rc = clk_set_rate(clk, rate);
if (rc < 0)
- pr_err("clk: couldn't set %s clock rate: %d\n",
- __clk_get_name(clk), rc);
+ pr_err("clk: couldn't set %s clock rate: %ld\n",
+ __clk_get_name(clk), clk_get_rate(clk));
clk_put(clk);
}
index++;
--
1.8.5.5

2015-04-13 04:56:35

by Mike Turquette

Subject: Re: [PATCH] clk: Show clock rate instead of return value

+Sylwester

Quoting Chanwoo Choi (2015-04-01 23:40:36)
> This patch shows the current clock rate instead of return value
> when clk_set_rate() return fail because log message means the clock rate.
>
> Cc: Mike Turquette <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Chanwoo Choi <[email protected]>
> ---
> drivers/clk/clk-conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index aad4796..fb1ee65 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -107,8 +107,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
>
> rc = clk_set_rate(clk, rate);
> if (rc < 0)
> - pr_err("clk: couldn't set %s clock rate: %d\n",
> - __clk_get_name(clk), rc);
> + pr_err("clk: couldn't set %s clock rate: %ld\n",
> + __clk_get_name(clk), clk_get_rate(clk));

Change seems OK, but what was Sylwester's original intent? We can always
look up the original/current rate in sysfs, but getting the error code
printed might be useful for debugging...

Regards,
Mike

> clk_put(clk);
> }
> index++;
> --
> 1.8.5.5
>

2015-04-13 08:12:20

by Sylwester Nawrocki

Subject: Re: [PATCH] clk: Show clock rate instead of return value

Hello,

On 13/04/15 06:56, Michael Turquette wrote:
> +Sylwester
>
> Quoting Chanwoo Choi (2015-04-01 23:40:36)
>> This patch shows the current clock rate instead of return value
>> when clk_set_rate() return fail because log message means the clock rate.
>>
>> Cc: Mike Turquette <[email protected]>
>> Cc: Stephen Boyd <[email protected]>
>> Signed-off-by: Chanwoo Choi <[email protected]>
>> ---
>> drivers/clk/clk-conf.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
>> index aad4796..fb1ee65 100644
>> --- a/drivers/clk/clk-conf.c
>> +++ b/drivers/clk/clk-conf.c
>> @@ -107,8 +107,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
>>
>> rc = clk_set_rate(clk, rate);
>> if (rc < 0)
>> - pr_err("clk: couldn't set %s clock rate: %d\n",
>> - __clk_get_name(clk), rc);
>> + pr_err("clk: couldn't set %s clock rate: %ld\n",
>> + __clk_get_name(clk), clk_get_rate(clk));
>
> Change seems OK, but what was Sylwester's original intent? We can always
> look up the original/current rate in sysfs, but getting the error code
> printed might be useful for debugging...

Indeed, I thought it was more useful to have the error code shown here.
Alternatively we could make it:

pr_err("clk: couldn't set %s clock rate to %ld (%d)\n",
__clk_get_name(clk), clk_get_rate(clk), rc);


--
Thanks
Sylwester