Hi Jason,
After merging the irqchip tree, today's linux-next build (x86_64
allmodconfig) failed like this:
kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
kernel/irq/generic-chip.c:408:2: error: implicit declaration of function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
^
Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
domain"). The only declaration of irq_domain_set_info() depends on
CONFIG_IRQ_DOMAIN_HIERARCHY.
I have used the irqchip tree from next-20150410 fot today.
--
Cheers,
Stephen Rothwell [email protected]
Hi Jason,
On 2015-04-13 09:05, Stephen Rothwell wrote:
> Hi Jason,
>
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
> kernel/irq/generic-chip.c:408:2: error: implicit declaration of
> function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
> irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
> ^
Hm, sorry about that, I did not notice that this function is only
available with domain hierarchy. I guess making domain hierarchy a
dependency of genirq is a bit harsh...
--
Stefan
>
> Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
> domain"). The only declaration of irq_domain_set_info() depends on
> CONFIG_IRQ_DOMAIN_HIERARCHY.
>
> I have used the irqchip tree from next-20150410 fot today.
Hi Stephen,
On Mon, Apr 13, 2015 at 05:05:39PM +1000, Stephen Rothwell wrote:
> Hi Jason,
>
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
> kernel/irq/generic-chip.c:408:2: error: implicit declaration of function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
> irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
> ^
>
> Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
> domain"). The only declaration of irq_domain_set_info() depends on
> CONFIG_IRQ_DOMAIN_HIERARCHY.
Sorry about that. I was rushing a bit in case the merge window was delayed a
week. It wasn't, so I'll drop this for v4.1.
It's also a gentle reminder that I need to do *more* thorough testing
with genirq changes before pushing. :-/
thx,
Jason.