2015-04-10 22:28:55

by Alexey Khoroshilov

[permalink] [raw]
Subject: [PATCH] dmaengine: pch_dma: fix memory leak on failure path in pch_dma_probe()

Memory allocated for pch_dma is not deallocated in case of failure
in pch_dma_probe().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <[email protected]>
---
drivers/dma/pch_dma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 35c143cb88da..b859792dde95 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -949,6 +949,7 @@ err_free_res:
err_disable_pdev:
pci_disable_device(pdev);
err_free_mem:
+ kfree(pd);
return err;
}

--
1.9.1


2015-04-17 18:17:21

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: pch_dma: fix memory leak on failure path in pch_dma_probe()

On Sat, Apr 11, 2015 at 01:28:41AM +0300, Alexey Khoroshilov wrote:
> Memory allocated for pch_dma is not deallocated in case of failure
> in pch_dma_probe().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
Applied, thanks

--
~Vinod