Subject: [PATCH] Staging: rtl8712: Removed unused variable

This patch removes unused variable in this file.

Signed-off-by: Gnanachandran Dhanapal <[email protected]>

Change-Id: I59cc869773d145239d62c3185018b275239fe812
---
drivers/staging/rtl8712/os_intfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 13debb5..c3ec419 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -128,7 +128,6 @@ static int netdev_close(struct net_device *pnetdev);

static uint loadparam(struct _adapter *padapter, struct net_device *pnetdev)
{
- uint status = _SUCCESS;
struct registry_priv *registry_par = &padapter->registrypriv;

registry_par->chip_version = (u8)chip_version;
@@ -172,7 +171,7 @@ static uint loadparam(struct _adapter *padapter, struct net_device *pnetdev)
registry_par->low_power = (u8)low_power;
registry_par->wifi_test = (u8) wifi_test;
r8712_initmac = initmac;
- return status;
+ return _SUCCESS;
}

static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p)
@@ -273,7 +272,6 @@ void r8712_stop_drv_timers(struct _adapter *padapter)

static u8 init_default_value(struct _adapter *padapter)
{
- u8 ret = _SUCCESS;
struct registry_priv *pregistrypriv = &padapter->registrypriv;
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -306,7 +304,7 @@ static u8 init_default_value(struct _adapter *padapter)
r8712_init_registrypriv_dev_network(padapter);
r8712_update_registrypriv_dev_network(padapter);
/*misc.*/
- return ret;
+ return _SUCCESS;
}

u8 r8712_init_drv_sw(struct _adapter *padapter)
--
1.7.9.5


2015-04-23 14:21:12

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] Staging: rtl8712: Removed unused variable

On Thu, Apr 23, 2015 at 02:12:44PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> This patch removes unused variable in this file.
>
> Signed-off-by: Gnanachandran Dhanapal <[email protected]>
>
> Change-Id: I59cc869773d145239d62c3185018b275239fe812

The only thing I can do with a patch that has this line in it is delete
it :(

Please fix and resend.

thanks,

greg k-h

Subject: RE: [PATCH] Staging: rtl8712: Removed unused variable

Thanks for the feedback, Greg.
I have sent patch set version 2 for the same changes.


-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: 23 April 2015 19:51
To: DHANAPAL, GNANACHANDRAN (G.)
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Babu, Viswanathan (V.)
Subject: Re: [PATCH] Staging: rtl8712: Removed unused variable

On Thu, Apr 23, 2015 at 02:12:44PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> This patch removes unused variable in this file.
>
> Signed-off-by: Gnanachandran Dhanapal <[email protected]>
>
> Change-Id: I59cc869773d145239d62c3185018b275239fe812

The only thing I can do with a patch that has this line in it is delete it :(

Please fix and resend.

thanks,

greg k-h