Hi,
Have you done anything about the tda998x audio support lately?
I was thinking of taking a shot at this now that I finally seem to have
some time for it. However, if you are just about to send another series
I'll wait for that first and see what makes the most sense after that.
My plan is to do something really simple first. No graph bindings or
anything fancy like that. Just a minimal dt-binding to for audio pin
configuration and use simple-card for the rest. I still try to make it
possible to support spdif and i2s at the same time, but I can not test
it as I do not have such HW.
I also try to make the ASoC part as generic as possible, so that it
could be reused by other HDMI encoders with spdif or i2s interface.
Best regards,
Jyri
On 01/20/15 21:35, Jean-Francois Moine wrote:
> Based on broonie/ASoC
>
> v10:
> - add the generic dt-card
> - define the audio ports from a DT graph of ports (Russell King)
> - reuse HDMI constants (Andrew Jackson - Jyri Sarha)
> - alloc rate_constraints in codec (Jyri Sarha)
> - fix bad number of channels (Jyri Sarha)
> - correct codec generation from config (Russell King - Jyri Sarha)
> - no module init/exit (Russell King)
> v9:
> - back to a TDA998x specific CODEC
> - more comments
> - change magic values to constants
> v8:
> - change some comments about the patches
> v7:
> - remove the change of the K predivider (Jyri Sarha)
> - add S24_3LE and S32_LE as possible audio formats (Jyri Sarha)
> - don't move the struct priv2 definition and use the
> slave encoder private data as the device private data
> (Russell King)
> - remove the useless request_module (Russell King/Mark Brown)
> - don't lock the HDMI module (Russell King)
> - use platform_device_unregister to remove the codec
> (Russell King)
> v6:
> - extend the HDMI CODEC instead of using a specific CODEC
> v5:
> - use the TDA998x private data instead of a specific area
> for the CODEC interface
> - the CODEC is TDA998x specific (Mark Brown)
> v4:
> - remove all the TDA998x specific stuff from the CODEC
> - move the EDID scan from the CODEC to the TDA998x
> - move the CODEC to sound/soc (Mark Brown)
> - update the audio_sample_rate from the EDID (Andrew Jackson)
> v3: fix bad rate (Andrew Jackson)
> v2: check double stream start (Mark Brown)
>
> Jean-Francois Moine (9):
> ASoC: kirkwood: dynamically build the DAI array
> ASoC: kirkwood: check the DAI type from the DAI name
> ASoC: kirkwood: accept the DAI definitions from a graph of ports
> drm/i2c: tda998x: Add support of a DT graph of ports
> drm/i2c: tda998x: Change drvdata for audio extension
> ASoC: tda998x: add a codec to the HDMI transmitter
> drm/i2c: tda998x: set cts_n according to the sample width
> ASoC: core: export snd_soc_get_dai_name
> ASoC: add generic dt-card support
>
> .../devicetree/bindings/drm/i2c/tda998x.txt | 51 ++++
> .../devicetree/bindings/sound/mvebu-audio.txt | 30 +++
> drivers/gpu/drm/i2c/tda998x_drv.c | 237 +++++++++++++++++-
> include/sound/soc.h | 2 +
> include/sound/tda998x.h | 32 +++
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/tda998x.c | 175 +++++++++++++
> sound/soc/generic/Kconfig | 2 +
> sound/soc/generic/Makefile | 2 +
> sound/soc/generic/dt-card.c | 275 +++++++++++++++++++++
> sound/soc/kirkwood/kirkwood-i2s.c | 141 ++++++-----
> sound/soc/kirkwood/kirkwood.h | 4 +-
> sound/soc/soc-core.c | 5 +-
> 14 files changed, 877 insertions(+), 86 deletions(-)
> create mode 100644 include/sound/tda998x.h
> create mode 100644 sound/soc/codecs/tda998x.c
> create mode 100644 sound/soc/generic/dt-card.c
>
On Mon, 27 Apr 2015 14:33:45 +0300
Jyri Sarha <[email protected]> wrote:
> Have you done anything about the tda998x audio support lately?
>
> I was thinking of taking a shot at this now that I finally seem to have
> some time for it. However, if you are just about to send another series
> I'll wait for that first and see what makes the most sense after that.
>
> My plan is to do something really simple first. No graph bindings or
> anything fancy like that. Just a minimal dt-binding to for audio pin
> configuration and use simple-card for the rest. I still try to make it
> possible to support spdif and i2s at the same time, but I can not test
> it as I do not have such HW.
>
> I also try to make the ASoC part as generic as possible, so that it
> could be reused by other HDMI encoders with spdif or i2s interface.
Hi Jyri,
I was busy on an other work, so, I did not advance on the tda998x.
If you look at the patch series, it contains 3 independant parts:
- dynamic building of the DAIs in the kirkwood audio controller,
- audio CODEC of the tda998x
- DT card based on audio graph
It seems that only the last part raised a problem.
Otherwise, the simple card works fine with the 2 first parts.
I am merging my patches in 4.1-rc1, and, as soon as I get an image on
my screen :), I will resubmit a patch series but about the tda998x
codec only.
Using i2s and s/pdif at the same time with the simple card asks for a
patch as the one I submitted in february 2014 (ASoC: simple-card: DT
fix and multi DAI links extension). As I am using my DT card, I will
not resubmit it. Eventually, the kirkwood patches are not critical.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
On Mon, 27 Apr 2015 20:25:02 +0200
Jean-Francois Moine <[email protected]> wrote:
> Using i2s and s/pdif at the same time with the simple card asks for a
> patch as the one I submitted in february 2014 (ASoC: simple-card: DT
> fix and multi DAI links extension).
Sorry, the patch was "ASoC: simple-card: Add multi-CODEC support"
submitted in january 2015:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-January/085855.html
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/