2015-04-30 11:57:33

by Preeti U Murthy

[permalink] [raw]
Subject: [PATCH] kernel: Replace reference to ASSIGN_ONCE with WRITE_ONCE in comment

Looks like commit :

43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)")

left behind a reference to ASSIGN_ONCE. Update this to WRITE_ONCE.

Signed-off-by: Preeti U Murthy <[email protected]>
---

include/linux/compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 0e41ca0..e65e0a7 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -446,7 +446,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
* with an explicit memory barrier or atomic instruction that provides the
* required ordering.
*
- * If possible use READ_ONCE/ASSIGN_ONCE instead.
+ * If possible use READ_ONCE/WRITE_ONCE instead.
*/
#define __ACCESS_ONCE(x) ({ \
__maybe_unused typeof(x) __var = (__force typeof(x)) 0; \


2015-04-30 12:09:28

by Christian Borntraeger

[permalink] [raw]
Subject: Re: [PATCH] kernel: Replace reference to ASSIGN_ONCE with WRITE_ONCE in comment

Am 30.04.2015 um 13:57 schrieb Preeti U Murthy:
> Looks like commit :
>
> 43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)")
>
> left behind a reference to ASSIGN_ONCE. Update this to WRITE_ONCE.
>
> Signed-off-by: Preeti U Murthy <[email protected]>

Acked-by: Christian Borntraeger <[email protected]>


> ---
>
> include/linux/compiler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 0e41ca0..e65e0a7 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -446,7 +446,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
> * with an explicit memory barrier or atomic instruction that provides the
> * required ordering.
> *
> - * If possible use READ_ONCE/ASSIGN_ONCE instead.
> + * If possible use READ_ONCE/WRITE_ONCE instead.
> */
> #define __ACCESS_ONCE(x) ({ \
> __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
>

Subject: [tip:locking/core] kernel: Replace reference to ASSIGN_ONCE() with WRITE_ONCE() in comment

Commit-ID: 663fdcbee0a656cdaef934e7f50e6c2670373bc9
Gitweb: http://git.kernel.org/tip/663fdcbee0a656cdaef934e7f50e6c2670373bc9
Author: Preeti U Murthy <[email protected]>
AuthorDate: Thu, 30 Apr 2015 17:27:21 +0530
Committer: Ingo Molnar <[email protected]>
CommitDate: Fri, 8 May 2015 12:28:53 +0200

kernel: Replace reference to ASSIGN_ONCE() with WRITE_ONCE() in comment

Looks like commit :

43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)")

left behind a reference to ASSIGN_ONCE(). Update this to WRITE_ONCE().

Signed-off-by: Preeti U Murthy <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: H. Peter Anvin <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
include/linux/compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 8677225..a7c0941 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -450,7 +450,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
* with an explicit memory barrier or atomic instruction that provides the
* required ordering.
*
- * If possible use READ_ONCE/ASSIGN_ONCE instead.
+ * If possible use READ_ONCE()/WRITE_ONCE() instead.
*/
#define __ACCESS_ONCE(x) ({ \
__maybe_unused typeof(x) __var = (__force typeof(x)) 0; \