2015-05-19 00:02:27

by Thomas Gleixner

Subject: [patch 5/6] x86, perf, cqm: Remove useless wrapper function

intel_cqm_event_del is a 1:1 wrapper for intel_cqm_event_stop. Remove
the useless gunk.

Signed-off-by: Thomas Gleixner <[email protected]>
---
arch/x86/kernel/cpu/perf_event_intel_cqm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

Index: linux/arch/x86/kernel/cpu/perf_event_intel_cqm.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/perf_event_intel_cqm.c
+++ linux/arch/x86/kernel/cpu/perf_event_intel_cqm.c
@@ -1033,11 +1033,6 @@ static int intel_cqm_event_add(struct pe
return 0;
}

-static void intel_cqm_event_del(struct perf_event *event, int mode)
-{
- intel_cqm_event_stop(event, mode);
-}
-
static void intel_cqm_event_destroy(struct perf_event *event)
{
struct perf_event *group_other = NULL;
@@ -1230,7 +1225,7 @@ static struct pmu intel_cqm_pmu = {
.task_ctx_nr = perf_sw_context,
.event_init = intel_cqm_event_init,
.add = intel_cqm_event_add,
- .del = intel_cqm_event_del,
+ .del = intel_cqm_event_stop,
.start = intel_cqm_event_start,
.stop = intel_cqm_event_stop,
.read = intel_cqm_event_read,

2015-05-19 09:18:27

by Matt Fleming

Subject: Re: [patch 5/6] x86, perf, cqm: Remove useless wrapper function

On Tue, 19 May, at 12:00:56AM, Thomas Gleixner wrote:
> intel_cqm_event_del is a 1:1 wrapper for intel_cqm_event_stop. Remove
> the useless gunk.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> ---
> arch/x86/kernel/cpu/perf_event_intel_cqm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Acked-by: Matt Fleming <[email protected]>

--
Matt Fleming, Intel Open Source Technology Center