2015-06-03 16:31:52

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH v8 2/7] clk: hi6220: Document devicetree bindings for hi6220 clock

Quoting Bintian Wang (2015-05-28 19:08:34)
> Document DT files bindings for Hisilicon hi6220 clock.
>
> Signed-off-by: Bintian Wang <[email protected]>
> Acked-by: Haojian Zhuang <[email protected]>
> Suggested-by: Arnd Bergmann <[email protected]>
> Acked-by: Stephen Boyd <[email protected]>

Acked-by: Michael Turquette <[email protected]>

> ---
> .../devicetree/bindings/clock/hi6220-clock.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/hi6220-clock.txt
>
> diff --git a/Documentation/devicetree/bindings/clock/hi6220-clock.txt b/Documentation/devicetree/bindings/clock/hi6220-clock.txt
> new file mode 100644
> index 0000000..53ddb19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/hi6220-clock.txt
> @@ -0,0 +1,34 @@
> +* Hisilicon Hi6220 Clock Controller
> +
> +Clock control registers reside in different Hi6220 system controllers,
> +please refer the following document to know more about the binding rules
> +for these system controllers:
> +
> +Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> +
> +Required Properties:
> +
> +- compatible: the compatible should be one of the following strings to
> + indicate the clock controller functionality.
> +
> + - "hisilicon,hi6220-aoctrl"
> + - "hisilicon,hi6220-sysctrl"
> + - "hisilicon,hi6220-mediactrl"
> + - "hisilicon,hi6220-pmctrl"
> +
> +- reg: physical base address of the controller and length of memory mapped
> + region.
> +
> +- #clock-cells: should be 1.
> +
> +For example:
> + sys_ctrl: sys_ctrl {
> + compatible = "hisilicon,hi6220-sysctrl", "syscon";
> + reg = <0x0 0xf7030000 0x0 0x2000>;
> + #clock-cells = <1>;
> + };
> +
> +Each clock is assigned an identifier and client nodes use this identifier
> +to specify the clock which they consume.
> +
> +All these identifier could be found in <dt-bindings/clock/hi6220-clock.h>.
> --
> 1.9.1
>