2015-06-05 19:16:39

by Neil Horman

[permalink] [raw]
Subject: Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

On Fri, Jun 05, 2015 at 01:41:02PM -0400, Nicholas Krause wrote:
> This makes the function sctp_assoc_lookup_laddr bool due to it
> only returning either one or zero as its return value. Further
> more this function can we simplified to return the if statement
> as part of this function directly and thus remove the no longer
> required if statement due to this function now being declared
> as bool.
>
> Signed-off-by: Nicholas Krause <[email protected]>

Acked-by: Neil Horman <[email protected]>


2015-06-05 21:56:40

by Andrej Manduch

[permalink] [raw]
Subject: Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

Hi Neil,

I would like to kindly ask you to always put full patch in reply when
you are replying to Nicks patch. Because he's banned from vger and only
people on cc are able to see his patches and this is only way for rest
of us to see what is in his patch.

Thanks.

On 06/05/2015 03:16 PM, Neil Horman wrote:
>> This makes the function sctp_assoc_lookup_laddr bool due to it
>> only returning either one or zero as its return value. Further
>> more this function can we simplified to return the if statement
>> as part of this function directly and thus remove the no longer
>> required if statement due to this function now being declared
>> as bool.
>>
>> Signed-off-by: Nicholas Krause <[email protected]>

--
Kind regards,
b.

2015-06-06 12:55:55

by Neil Horman

[permalink] [raw]
Subject: Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

On Fri, Jun 05, 2015 at 05:56:33PM -0400, Andrej Manduch wrote:
> Hi Neil,
>
> I would like to kindly ask you to always put full patch in reply when
> you are replying to Nicks patch. Because he's banned from vger and only
> people on cc are able to see his patches and this is only way for rest
> of us to see what is in his patch.
>
> Thanks.
Sure, though that begs the question, why is he banned from vger? Is it his
gmail address, or something more directed?

Neil

>
> On 06/05/2015 03:16 PM, Neil Horman wrote:
> >> This makes the function sctp_assoc_lookup_laddr bool due to it
> >> only returning either one or zero as its return value. Further
> >> more this function can we simplified to return the if statement
> >> as part of this function directly and thus remove the no longer
> >> required if statement due to this function now being declared
> >> as bool.
> >>
> >> Signed-off-by: Nicholas Krause <[email protected]>
>
> --
> Kind regards,
> b.
>