2015-06-05 14:10:29

by Guenter Roeck

[permalink] [raw]
Subject: [PATCH -next] cris: Fix system call references for cris v10

The newly wired system calls cause compile errors when building
crisv10 images.

arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x580): undefined reference to `_sys_sched_setattr'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x584): undefined reference to `_sys_sched_getattr'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x588): undefined reference to `_sys_renameat2'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x58c): undefined reference to `_sys_seccomp'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x590): undefined reference to `_sys_getrandom'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x594): undefined reference to `_sys_memfd_create'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x598): undefined reference to `_sys_bpf'
arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x59c): undefined reference to `_sys_execveat'

Fixes: 3e48d266639b ("CRIS: Wire up missing syscalls")
Cc: Chen Gang <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
arch/cris/arch-v10/kernel/entry.S | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/cris/arch-v10/kernel/entry.S b/arch/cris/arch-v10/kernel/entry.S
index d94c520dff10..b5622521dad5 100644
--- a/arch/cris/arch-v10/kernel/entry.S
+++ b/arch/cris/arch-v10/kernel/entry.S
@@ -955,14 +955,14 @@ sys_call_table:
.long sys_process_vm_writev
.long sys_kcmp /* 350 */
.long sys_finit_module
- .long _sys_sched_setattr
- .long _sys_sched_getattr
- .long _sys_renameat2
- .long _sys_seccomp /* 355 */
- .long _sys_getrandom
- .long _sys_memfd_create
- .long _sys_bpf
- .long _sys_execveat
+ .long sys_sched_setattr
+ .long sys_sched_getattr
+ .long sys_renameat2
+ .long sys_seccomp /* 355 */
+ .long sys_getrandom
+ .long sys_memfd_create
+ .long sys_bpf
+ .long sys_execveat

/*
* NOTE!! This doesn't have to be exact - we just have
--
2.1.0


2015-06-08 07:18:01

by Jesper Nilsson

[permalink] [raw]
Subject: Re: [PATCH -next] cris: Fix system call references for cris v10

On Fri, Jun 05, 2015 at 04:10:19PM +0200, Guenter Roeck wrote:
> The newly wired system calls cause compile errors when building
> crisv10 images.
>
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x580): undefined reference to `_sys_sched_setattr'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x584): undefined reference to `_sys_sched_getattr'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x588): undefined reference to `_sys_renameat2'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x58c): undefined reference to `_sys_seccomp'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x590): undefined reference to `_sys_getrandom'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x594): undefined reference to `_sys_memfd_create'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x598): undefined reference to `_sys_bpf'
> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0x59c): undefined reference to `_sys_execveat'
>
> Fixes: 3e48d266639b ("CRIS: Wire up missing syscalls")
> Cc: Chen Gang <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>

Hi Guenter!

Thanks, a similar patch should already be folded into the
original tree, could you verify with the latest for-next/linux-next?

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2015-06-08 14:50:01

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH -next] cris: Fix system call references for cris v10

On 06/08/2015 12:17 AM, Jesper Nilsson wrote:
> On Fri, Jun 05, 2015 at 04:10:19PM +0200, Guenter Roeck wrote:
>> The newly wired system calls cause compile errors when building
>> crisv10 images.
>>
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x580): undefined reference to `_sys_sched_setattr'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x584): undefined reference to `_sys_sched_getattr'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x588): undefined reference to `_sys_renameat2'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x58c): undefined reference to `_sys_seccomp'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x590): undefined reference to `_sys_getrandom'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x594): undefined reference to `_sys_memfd_create'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x598): undefined reference to `_sys_bpf'
>> arch/cris/arch-v10/kernel/built-in.o: In function `sys_call_table':
>> (.rodata+0x59c): undefined reference to `_sys_execveat'
>>
>> Fixes: 3e48d266639b ("CRIS: Wire up missing syscalls")
>> Cc: Chen Gang <[email protected]>
>> Signed-off-by: Guenter Roeck <[email protected]>
>
> Hi Guenter!
>
> Thanks, a similar patch should already be folded into the
> original tree, could you verify with the latest for-next/linux-next?
>

Yes, the cris/crisv32 images build fine in the latest -next.

Guenter