2015-06-11 10:40:30

by Maninder Singh

Subject: [PATCH v2] arm:arm64/hw_breakpoint.c: Remove unnecessary header

Header <asm/kdebug.h> is not needed in hw_breakpoint.c
for arm as well as arm64.
Removing the same.

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
---
arch/arm/kernel/hw_breakpoint.c | 1 -
arch/arm64/kernel/hw_breakpoint.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/kernel/hw_breakpoint.c
b/arch/arm/kernel/hw_breakpoint.c
index dc7d0a9..6284779 100644
--- a/arch/arm/kernel/hw_breakpoint.c
+++ b/arch/arm/kernel/hw_breakpoint.c
@@ -35,7 +35,6 @@
#include <asm/cputype.h>
#include <asm/current.h>
#include <asm/hw_breakpoint.h>
-#include <asm/kdebug.h>
#include <asm/traps.h>

/* Breakpoint currently in use for each BRP. */
diff --git a/arch/arm64/kernel/hw_breakpoint.c
b/arch/arm64/kernel/hw_breakpoint.c
index e7d934d..7a1a5da 100644
--- a/arch/arm64/kernel/hw_breakpoint.c
+++ b/arch/arm64/kernel/hw_breakpoint.c
@@ -31,7 +31,6 @@
#include <asm/current.h>
#include <asm/debug-monitors.h>
#include <asm/hw_breakpoint.h>
-#include <asm/kdebug.h>
#include <asm/traps.h>
#include <asm/cputype.h>
#include <asm/system_misc.h>
--
1.7.1

2015-06-11 15:29:47

by Will Deacon

Subject: Re: [PATCH v2] arm:arm64/hw_breakpoint.c: Remove unnecessary header

On Thu, Jun 11, 2015 at 11:39:58AM +0100, Maninder Singh wrote:
> Header <asm/kdebug.h> is not needed in hw_breakpoint.c
> for arm as well as arm64.
> Removing the same.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>
> ---
> arch/arm/kernel/hw_breakpoint.c | 1 -
> arch/arm64/kernel/hw_breakpoint.c | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)

Sorry for the bother, but can you send this as two separate patches please?
They'll need to go via two different trees to get into mainline.

Will

2015-06-11 16:13:13

by Catalin Marinas

Subject: Re: [PATCH v2] arm:arm64/hw_breakpoint.c: Remove unnecessary header

On Thu, Jun 11, 2015 at 04:29:43PM +0100, Will Deacon wrote:
> On Thu, Jun 11, 2015 at 11:39:58AM +0100, Maninder Singh wrote:
> > Header <asm/kdebug.h> is not needed in hw_breakpoint.c
> > for arm as well as arm64.
> > Removing the same.
> >
> > Signed-off-by: Maninder Singh <[email protected]>
> > Reviewed-by: Vaneet Narang <[email protected]>
> > ---
> > arch/arm/kernel/hw_breakpoint.c | 1 -
> > arch/arm64/kernel/hw_breakpoint.c | 1 -
> > 2 files changed, 0 insertions(+), 2 deletions(-)
>
> Sorry for the bother, but can you send this as two separate patches please?
> They'll need to go via two different trees to get into mainline.

Or just send it to [email protected].

--
Catalin

2015-06-15 03:08:46

by Maninder Singh

Subject: Re: [PATCH v2] arm:arm64/hw_breakpoint.c: Remove unnecessary header

>On Thu, Jun 11, 2015 at 04:29:43PM +0100, Will Deacon wrote:
>> On Thu, Jun 11, 2015 at 11:39:58AM +0100, Maninder Singh wrote:
>> > Header <asm/kdebug.h> is not needed in hw_breakpoint.c
>> > for arm as well as arm64.
>> > Removing the same.
>> >
>> > Signed-off-by: Maninder Singh <[email protected]>
>> > Reviewed-by: Vaneet Narang <[email protected]>
>> > ---
>> > arch/arm/kernel/hw_breakpoint.c | 1 -
>> > arch/arm64/kernel/hw_breakpoint.c | 1 -
>> > 2 files changed, 0 insertions(+), 2 deletions(-)
>>
>> Sorry for the bother, but can you send this as two separate patches please?
>> They'll need to go via two different trees to get into mainline.
>
>Or just send it to [email protected].
>
>--
>Catalin

Sure, I am sending two separate patches.

Thanks????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?