2015-06-12 12:22:23

by Anda-Maria Nicolae

[permalink] [raw]

Subject: [PATCH] power_supply: rt9455_charger: Fix error reported by static analysis tool

---

The result of container_of macro cannot be NULL, so there is no need to
check whether info is NULL.

Signed-off-by: Anda-Maria Nicolae <[email protected]>
---
drivers/power/rt9455_charger.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/power/rt9455_charger.c b/drivers/power/rt9455_charger.c
index de86913..08baac6 100644
--- a/drivers/power/rt9455_charger.c
+++ b/drivers/power/rt9455_charger.c
@@ -1412,9 +1412,6 @@ static int rt9455_usb_event(struct notifier_block *nb,
unsigned int opa_mode, iaicr;
int ret;

- if (!info)
- return NOTIFY_DONE;
-
/*
* Determine whether the charger is in charge mode
* or in boost mode.
--
1.7.9.5

2015-06-13 02:40:39

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power_supply: rt9455_charger: Fix error reported by static analysis tool

---

Hi,

On Fri, Jun 12, 2015 at 03:25:51PM +0300, Anda-Maria Nicolae wrote:
> The result of container_of macro cannot be NULL, so there is no need to
> check whether info is NULL.

Thanks, queued for 4.2.

-- Sebastian

---

Attachments:

(No filename) (216.00 B)
signature.asc (819.00 B)
Digital signature Download all attachments