2015-06-15 12:20:16

by Andrea Parri

Subject: [PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
because already performed in hlist_del_init(), so remove it.

Signed-off-by: Andrea Parri <[email protected]>
---
net/sched/sch_qfq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index 3ec7e88..b8d73bc 100644
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -339,8 +339,7 @@ static struct qfq_aggregate *qfq_choose_next_agg(struct qfq_sched *);

static void qfq_destroy_agg(struct qfq_sched *q, struct qfq_aggregate *agg)
{
- if (!hlist_unhashed(&agg->nonfull_next))
- hlist_del_init(&agg->nonfull_next);
+ hlist_del_init(&agg->nonfull_next);
q->wsum -= agg->class_weight;
if (q->wsum != 0)
q->iwsum = ONE_FP / q->wsum;

2015-06-16 00:20:18

by David Miller

Subject: Re: [PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

From: Andrea Parri <[email protected]>
Date: Mon, 15 Jun 2015 14:20:01 +0200

> The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
> because already performed in hlist_del_init(), so remove it.
>
> Signed-off-by: Andrea Parri <[email protected]>

This patch has been corrupted by your email client (TAB characters
have been transformed into sequences of SPACEs, etc.)

Please fix this up and resubmit.