2015-06-26 02:26:11

by Walter Lozano

Subject: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating

This patch fixes the formating of DTS bindings for the adxl34x digital
accelerometer.

Signed-off-by: Walter Lozano <[email protected]>
---
arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index 71468a7..5b60692 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -73,14 +73,14 @@
status = "okay";
};

-&i2c1{
+&i2c1 {
status = "okay";

- accel1: accel1@53{
+ accel1: accelerometer@53 {
compatible = "adxl34x";
reg = <0x53>;

- interrupt-parent = < &portc >;
+ interrupt-parent = <&portc>;
interrupts = <3 2>;
};
};
--
1.7.10.4

2015-06-26 02:26:22

by Walter Lozano

Subject: [PATCH 2/3] ARM: socfpga: dts: Fix entries order

This patch reorders the nodes alphabetically

Signed-off-by: Walter Lozano <[email protected]>
---
arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index 5b60692..d343e03 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -60,15 +60,6 @@
rxc-skew-ps = <2000>;
};

-&mmc0 {
- vmmc-supply = <&regulator_3_3v>;
- vqmmc-supply = <&regulator_3_3v>;
-};
-
-&usb1 {
- status = "okay";
-};
-
&gpio2 {
status = "okay";
};
@@ -84,3 +75,12 @@
interrupts = <3 2>;
};
};
+
+&mmc0 {
+ vmmc-supply = <&regulator_3_3v>;
+ vqmmc-supply = <&regulator_3_3v>;
+};
+
+&usb1 {
+ status = "okay";
+};
--
1.7.10.4

2015-06-26 02:26:45

by Walter Lozano

Subject: [PATCH 3/3] ARM: socfpga: dts: Fix adxl345 compatible string

This patch fixes the compatible string for adxl345 digital accelerometer
after the deprecation of compatible string adxl345x.

Signed-off-by: Walter Lozano <[email protected]>
---
arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index d343e03..5e17fd1 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -68,7 +68,7 @@
status = "okay";

accel1: accelerometer@53 {
- compatible = "adxl34x";
+ compatible = "adi,adxl345";
reg = <0x53>;

interrupt-parent = <&portc>;
--
1.7.10.4

2015-06-26 07:17:26

by Steffen Trumtrar

Subject: Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating

Hi Walter!

On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
> This patch fixes the formating of DTS bindings for the adxl34x digital
> accelerometer.
>
> Signed-off-by: Walter Lozano <[email protected]>
> ---
> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> index 71468a7..5b60692 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> @@ -73,14 +73,14 @@
> status = "okay";
> };
>
> -&i2c1{
> +&i2c1 {
> status = "okay";
>
> - accel1: accel1@53{
> + accel1: accelerometer@53 {
> compatible = "adxl34x";
> reg = <0x53>;
>
> - interrupt-parent = < &portc >;
> + interrupt-parent = <&portc>;
> interrupts = <3 2>;
> };
> };

I would personally squash 3/3 into this one, but otherwise:

Whole series

Acked-by: Steffen Trumtrar <[email protected]>

Thanks,
Steffen

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2015-06-26 10:36:53

by Walter Lozano

Subject: Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating

Hi Steffen

On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
<[email protected]> wrote:
> Hi Walter!
>
> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>> This patch fixes the formating of DTS bindings for the adxl34x digital
>> accelerometer.
>>
>> Signed-off-by: Walter Lozano <[email protected]>
>> ---
>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> index 71468a7..5b60692 100644
>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> @@ -73,14 +73,14 @@
>> status = "okay";
>> };
>>
>> -&i2c1{
>> +&i2c1 {
>> status = "okay";
>>
>> - accel1: accel1@53{
>> + accel1: accelerometer@53 {
>> compatible = "adxl34x";
>> reg = <0x53>;
>>
>> - interrupt-parent = < &portc >;
>> + interrupt-parent = <&portc>;
>> interrupts = <3 2>;
>> };
>> };
>
> I would personally squash 3/3 into this one, but otherwise:
>
> Whole series
>
> Acked-by: Steffen Trumtrar <[email protected]>
>

Thanks for your comments. I have no problem at all. Dinh?

Regards

--
Walter Lozano, VanguardiaSur
http://www.vanguardiasur.com.ar

2015-07-07 14:00:04

by Dinh Nguyen

Subject: Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating

On 6/26/15 5:36 AM, Walter Lozano wrote:
> Hi Steffen
>
> On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
> <[email protected]> wrote:
>> Hi Walter!
>>
>> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>>> This patch fixes the formating of DTS bindings for the adxl34x digital
>>> accelerometer.
>>>
>>> Signed-off-by: Walter Lozano <[email protected]>
>>> ---
>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> index 71468a7..5b60692 100644
>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> @@ -73,14 +73,14 @@
>>> status = "okay";
>>> };
>>>
>>> -&i2c1{
>>> +&i2c1 {
>>> status = "okay";
>>>
>>> - accel1: accel1@53{
>>> + accel1: accelerometer@53 {
>>> compatible = "adxl34x";
>>> reg = <0x53>;
>>>
>>> - interrupt-parent = < &portc >;
>>> + interrupt-parent = <&portc>;
>>> interrupts = <3 2>;
>>> };
>>> };
>>
>> I would personally squash 3/3 into this one, but otherwise:
>>
>> Whole series
>>
>> Acked-by: Steffen Trumtrar <[email protected]>
>>
>
> Thanks for your comments. I have no problem at all. Dinh?

I've applied and squashed 1/3 and 3/3 together.

Thanks,
Dinh

2015-07-07 14:06:14

by Walter Lozano

Subject: Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating

On Tue, Jul 7, 2015 at 11:00 AM, Dinh Nguyen
<[email protected]> wrote:
>
>
> On 6/26/15 5:36 AM, Walter Lozano wrote:
>> Hi Steffen
>>
>> On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
>> <[email protected]> wrote:
>>> Hi Walter!
>>>
>>> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>>>> This patch fixes the formating of DTS bindings for the adxl34x digital
>>>> accelerometer.
>>>>
>>>> Signed-off-by: Walter Lozano <[email protected]>
>>>> ---
>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> index 71468a7..5b60692 100644
>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> @@ -73,14 +73,14 @@
>>>> status = "okay";
>>>> };
>>>>
>>>> -&i2c1{
>>>> +&i2c1 {
>>>> status = "okay";
>>>>
>>>> - accel1: accel1@53{
>>>> + accel1: accelerometer@53 {
>>>> compatible = "adxl34x";
>>>> reg = <0x53>;
>>>>
>>>> - interrupt-parent = < &portc >;
>>>> + interrupt-parent = <&portc>;
>>>> interrupts = <3 2>;
>>>> };
>>>> };
>>>
>>> I would personally squash 3/3 into this one, but otherwise:
>>>
>>> Whole series
>>>
>>> Acked-by: Steffen Trumtrar <[email protected]>
>>>
>>
>> Thanks for your comments. I have no problem at all. Dinh?
>
> I've applied and squashed 1/3 and 3/3 together.
>

Great! Thanks!

--
Walter Lozano, VanguardiaSur
http://www.vanguardiasur.com.ar