2015-06-28 16:55:05

by Ravi Teja

[permalink] [raw]
Subject: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings


This patch fixes checkpatch warnings

Signed-off-by: Ravi Teja Darbha <[email protected]>
---
drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index bb8087e..62f7f68 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
static int
visorchipset_chipset_selftest(void)
{
- char env_selftest[20];
- char *envp[] = { env_selftest, NULL };
+ static char env_selftest[20];
+ static const char * const envp[] = { env_selftest, NULL };

sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
@@ -1559,9 +1559,9 @@ static void
parahotplug_request_kickoff(struct parahotplug_request *req)
{
struct controlvm_message_packet *cmd = &req->msg.cmd;
- char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
- env_func[40];
- char *envp[] = {
+ static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
+ env_dev[40], env_func[40];
+ static const char * const envp[] = {
env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
};

--
1.9.1


2015-06-29 03:18:20

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings

What warnings? Be specific please.

2015-06-29 08:30:09

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
>

This patch is scary for how wrong it looks. But the changelog is
definitely wrong so I'm not going to try understand the patch.

regards,
dan carpenter

2015-06-29 13:50:50

by Don Zickus

[permalink] [raw]
Subject: Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
>
> Signed-off-by: Ravi Teja Darbha <[email protected]>

David,

Is this code removed after you ripped out the parahotplug stuff?
IOW, the next round of updates from Ben might obsolete this patch.

Cheers,
Don

> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index bb8087e..62f7f68 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
> static int
> visorchipset_chipset_selftest(void)
> {
> - char env_selftest[20];
> - char *envp[] = { env_selftest, NULL };
> + static char env_selftest[20];
> + static const char * const envp[] = { env_selftest, NULL };
>
> sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
> kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
> @@ -1559,9 +1559,9 @@ static void
> parahotplug_request_kickoff(struct parahotplug_request *req)
> {
> struct controlvm_message_packet *cmd = &req->msg.cmd;
> - char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
> - env_func[40];
> - char *envp[] = {
> + static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
> + env_dev[40], env_func[40];
> + static const char * const envp[] = {
> env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
> };
>
> --
> 1.9.1
>