2015-07-13 12:50:57

by Dmitry Kalinkin

Subject: [PATCH] staging: android: ion: reorder variable definitions

Prevents false positive "missing empty line after a definition"
checkpatch warning.

Signed-off-by: Dmitry Kalinkin <[email protected]>
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..6c922c7 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1103,10 +1103,10 @@ static struct dma_buf_ops dma_buf_ops = {
struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_handle *handle)
{
+ DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
- DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

mutex_lock(&client->lock);
valid_handle = ion_handle_validate(client, handle);
--
1.8.3.1

2015-07-13 13:33:27

by Dan Carpenter

Subject: Re: [PATCH] staging: android: ion: reorder variable definitions

On Mon, Jul 13, 2015 at 03:50:30PM +0300, Dmitry Kalinkin wrote:
> Prevents false positive "missing empty line after a definition"
> checkpatch warning.
>
> Signed-off-by: Dmitry Kalinkin <[email protected]>
> ---

Clap clap clap. :)

regards,
dan carpenter