2015-07-13 20:31:19

by Thomas Gleixner

Subject: [patch 2/3] avr32/at32ap: Use irq_set_handler_locked()

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and replacement was done with coccinelle.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Jiang Liu <[email protected]>
Cc: Julia Lawall <[email protected]>
Cc: Haavard Skinnemoen <[email protected]>
Cc: Hans-Christian Egtvedt <[email protected]>
---
arch/avr32/mach-at32ap/extint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: tip/arch/avr32/mach-at32ap/extint.c
===================================================================
--- tip.orig/arch/avr32/mach-at32ap/extint.c
+++ tip/arch/avr32/mach-at32ap/extint.c
@@ -128,9 +128,9 @@ static int eic_set_irq_type(struct irq_d

irqd_set_trigger_type(d, flow_type);
if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
- __irq_set_handler_locked(irq, handle_level_irq);
+ irq_set_handler_locked(d, handle_level_irq);
else
- __irq_set_handler_locked(irq, handle_edge_irq);
+ irq_set_handler_locked(d, handle_edge_irq);

return IRQ_SET_MASK_OK_NOCOPY;
}

2015-07-15 11:52:12

by Hans-Christian Noren Egtvedt

Subject: Re: [patch 2/3] avr32/at32ap: Use irq_set_handler_locked()

Around Mon 13 Jul 2015 20:31:10 -0000 or thereabout, Thomas Gleixner wrote:
> Use irq_set_handler_locked() as it avoids a redundant lookup of the
> irq descriptor.
>
> Search and replacement was done with coccinelle.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Jiang Liu <[email protected]>
> Cc: Julia Lawall <[email protected]>
> Cc: Haavard Skinnemoen <[email protected]>
> Cc: Hans-Christian Egtvedt <[email protected]>

Acked-by: Hans-Christian Egtvedt <[email protected]>

> ---
> arch/avr32/mach-at32ap/extint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: tip/arch/avr32/mach-at32ap/extint.c
> ===================================================================
> --- tip.orig/arch/avr32/mach-at32ap/extint.c
> +++ tip/arch/avr32/mach-at32ap/extint.c
> @@ -128,9 +128,9 @@ static int eic_set_irq_type(struct irq_d
>
> irqd_set_trigger_type(d, flow_type);
> if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
> - __irq_set_handler_locked(irq, handle_level_irq);
> + irq_set_handler_locked(d, handle_level_irq);
> else
> - __irq_set_handler_locked(irq, handle_edge_irq);
> + irq_set_handler_locked(d, handle_edge_irq);
>
> return IRQ_SET_MASK_OK_NOCOPY;
> }
--
mvh
Hans-Christian Egtvedt

2015-07-27 06:13:58

by tip-bot for Vasyl Gomonovych

Subject: [tip:irq/core] avr32/at32ap: Use irq_set_handler_locked()

Commit-ID: 4f31dd63e050b777d3f3139197c4b3860aa89301
Gitweb: http://git.kernel.org/tip/4f31dd63e050b777d3f3139197c4b3860aa89301
Author: Thomas Gleixner <[email protected]>
AuthorDate: Mon, 13 Jul 2015 20:31:10 +0000
Committer: Thomas Gleixner <[email protected]>
CommitDate: Sun, 26 Jul 2015 11:47:25 +0200

avr32/at32ap: Use irq_set_handler_locked()

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and replacement was done with coccinelle.

Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Hans-Christian Egtvedt <[email protected]>
Cc: Haavard Skinnemoen <[email protected]>
Cc: Jiang Liu <[email protected]>
Cc: Julia Lawall <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
arch/avr32/mach-at32ap/extint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c
index 2d48b6a..d51ff8f 100644
--- a/arch/avr32/mach-at32ap/extint.c
+++ b/arch/avr32/mach-at32ap/extint.c
@@ -128,9 +128,9 @@ static int eic_set_irq_type(struct irq_data *d, unsigned int flow_type)

irqd_set_trigger_type(d, flow_type);
if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
- __irq_set_handler_locked(irq, handle_level_irq);
+ irq_set_handler_locked(d, handle_level_irq);
else
- __irq_set_handler_locked(irq, handle_edge_irq);
+ irq_set_handler_locked(d, handle_edge_irq);

return IRQ_SET_MASK_OK_NOCOPY;
}