2015-07-27 15:02:29

by Guenter Roeck

Subject: [PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

Commit 65525488fa86 ("proc: add kpageidle file") introduces code
which depends on MMU_NOTIFIER, yet the newly introduced configuration
flag does not declare that dependency. This results in the following
build failures seen if IDLE_PAGE_TRACKING is configured but MMU_NOTIFIER
is not.

fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
fs/proc/page.c:341:4: error:
implicit declaration of function 'pmdp_clear_young_notify'
fs/proc/page.c:347:4: error:
implicit declaration of function 'ptep_clear_young_notify'

Fixes: 65525488fa86 ("proc: add kpageidle file")
Cc: Andrew Morton <[email protected]>
Cc: Andres Lagar-Cavilla <[email protected]>
Cc: Vladimir Davydov <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
mm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 7e9ccb438985..b73b41c3217b 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -651,6 +651,7 @@ config DEFERRED_STRUCT_PAGE_INIT

config IDLE_PAGE_TRACKING
bool "Enable idle page tracking"
+ depends on MMU_NOTIFIER
select PROC_PAGE_MONITOR
select PAGE_EXTENSION if !64BIT
help
--
2.1.0

2015-07-27 15:17:27

by Vladimir Davydov

Subject: Re: [PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

On Mon, Jul 27, 2015 at 08:02:23AM -0700, Guenter Roeck wrote:

> fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
> fs/proc/page.c:341:4: error:
> implicit declaration of function 'pmdp_clear_young_notify'
> fs/proc/page.c:347:4: error:
> implicit declaration of function 'ptep_clear_young_notify'

The issue has already been reported and fixed, see
http://www.spinics.net/lists/linux-mm/msg92023.html

Thanks,
Vladimir