2015-07-30 09:23:41

by Matias Bjørling

Subject: [PATCH] NVMe: removed unused nn var from nvme_dev_add

The logic in nvme_dev_add to enumerate namespaces was moved to
nvme_dev_scan. When moved, the nn variable is no longer used. This patch
removes it.

Fixes: a5768aai ("NVMe: Automatic namespace rescan")
Signed-off-by: Matias Bjørling <[email protected]>
---
drivers/block/nvme-core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d844ec4..82a3241 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2344,7 +2344,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
{
struct pci_dev *pdev = to_pci_dev(dev->dev);
int res;
- unsigned nn;
struct nvme_id_ctrl *ctrl;
int shift = NVME_CAP_MPSMIN(readq(&dev->bar->cap)) + 12;

@@ -2354,7 +2353,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
return -EIO;
}

- nn = le32_to_cpup(&ctrl->nn);
dev->oncs = le16_to_cpup(&ctrl->oncs);
dev->abort_limit = ctrl->acl + 1;
dev->vwc = ctrl->vwc;
--
2.1.4

2015-08-04 11:28:36

by Christoph Hellwig

Subject: Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2015-08-17 23:19:35

by Matias Bjørling

Subject: Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add

Can this be picked up?

Thanks

On Tue, Aug 4, 2015 at 1:28 PM, Christoph Hellwig <[email protected]> wrote:
> Looks good,
>
> Reviewed-by: Christoph Hellwig <[email protected]>
>
> _______________________________________________
> Linux-nvme mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-nvme

2015-08-18 16:14:42

by Jens Axboe

Subject: Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add

On 08/17/2015 05:19 PM, Matias Bjørling wrote:
> Can this be picked up?

Applied.

--
Jens Axboe