2015-05-14 16:52:05

by Nicholas Mc Guire

Subject: [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type

Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.

API conformance testing for completions with coccinelle spatches are being
used to locate API usage inconsistencies:
./drivers/net/wireless/ath/ath9k/wmi.c:331
int return assigned to unsigned long

Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
CONFIG_ATH9K_HTC=m

Patch is against 4.1-rc3 (localversion-next is -next-20150514)

Signed-off-by: Nicholas Mc Guire <[email protected]>
---
drivers/net/wireless/ath/ath9k/wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c
index ca533b4..a1458db 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.c
+++ b/drivers/net/wireless/ath/ath9k/wmi.c
@@ -299,7 +299,8 @@ int ath9k_wmi_cmd(struct wmi *wmi, enum wmi_cmd_id cmd_id,
sizeof(struct wmi_cmd_hdr);
struct sk_buff *skb;
u8 *data;
- int time_left, ret = 0;
+ unsigned long time_left;
+ int ret = 0;

if (ah->ah_flags & AH_UNPLUGGED)
return 0;
--
1.7.10.4

2015-05-14 17:05:48

by Kalle Valo

Subject: Re: [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type

Nicholas Mc Guire <[email protected]> writes:

> Patch is against 4.1-rc3 (localversion-next is -next-20150514)

BTW, this info should be under "---" line so that it doesn't get stored
to the actual commit log.

--
Kalle Valo

2015-05-14 17:40:31

by Nicholas Mc Guire

Subject: Re: [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type

On Thu, 14 May 2015, Kalle Valo wrote:

> Nicholas Mc Guire <[email protected]> writes:
>
> > Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
> BTW, this info should be under "---" line so that it doesn't get stored
> to the actual commit log.
>
that is where I had been putting it until ask by Josh Triplett and
Steven Rostedt to put it above the "---" line explicitly
see: http://lkml.org/lkml/2015/5/11/552

So now I'm a bit lost where to actually put this buildtest info ?

thx!
hofrat

2015-05-21 13:59:20

by Kalle Valo

Subject: Re: [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type

Nicholas Mc Guire <[email protected]> writes:

> On Thu, 14 May 2015, Kalle Valo wrote:
>
>> Nicholas Mc Guire <[email protected]> writes:
>>
>> > Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>>
>> BTW, this info should be under "---" line so that it doesn't get stored
>> to the actual commit log.
>>
> that is where I had been putting it until ask by Josh Triplett and
> Steven Rostedt to put it above the "---" line explicitly
> see: http://lkml.org/lkml/2015/5/11/552
>
> So now I'm a bit lost where to actually put this buildtest info ?

Different maintainers have different opinions, there is no one answer,
but if Steven is okay to have this in the commit log so am I. So no need
to change anything.

--
Kalle Valo

2015-08-13 12:26:58

by Kalle Valo

Subject: Re: ath9k_htc: wmi: match wait_for_completion_timeout return type

> Return type of wait_for_completion_timeout is unsigned long not int.
> As time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
> API conformance testing for completions with coccinelle spatches are being
> used to locate API usage inconsistencies:
> ./drivers/net/wireless/ath/ath9k/wmi.c:331
> int return assigned to unsigned long
>
> Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
> CONFIG_ATH9K_HTC=m
>
> Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo