2015-08-03 01:30:39

by Leo Yan

Subject: [PATCH] Documentation: minor typo fix in mailbox.txt

Fix minor typo so that can pass correct pointer variable for
container_of().

Signed-off-by: Leo Yan <[email protected]>
---
Documentation/mailbox.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/mailbox.txt b/Documentation/mailbox.txt
index 1092ad9..f3f0ac2 100644
--- a/Documentation/mailbox.txt
+++ b/Documentation/mailbox.txt
@@ -51,8 +51,8 @@ struct demo_client {
*/
static void message_from_remote(struct mbox_client *cl, void *mssg)
{
- struct demo_client *dc = container_of(mbox_client,
- struct demo_client, cl);
+ struct demo_client *dc = container_of(cl,
+ struct demo_client, cl);
if (dc->async) {
if (is_an_ack(mssg)) {
/* An ACK to our last sample sent */
@@ -68,8 +68,8 @@ static void message_from_remote(struct mbox_client *cl, void *mssg)

static void sample_sent(struct mbox_client *cl, void *mssg, int r)
{
- struct demo_client *dc = container_of(mbox_client,
- struct demo_client, cl);
+ struct demo_client *dc = container_of(cl,
+ struct demo_client, cl);
complete(&dc->c);
}

--
1.9.1

2015-08-14 00:04:15

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: minor typo fix in mailbox.txt

On Mon, 3 Aug 2015 09:30:25 +0800
Leo Yan <[email protected]> wrote:

> Fix minor typo so that can pass correct pointer variable for
> container_of().

Looks good to me, applied to the docs tree. I also took the opportunity
to eliminate the (now) needless line-splitting on the affected lines.

Thanks,

jon

2015-08-14 05:49:25

by Leo Yan

Subject: Re: [PATCH] Documentation: minor typo fix in mailbox.txt

On Thu, Aug 13, 2015 at 06:04:11PM -0600, Jonathan Corbet wrote:
> On Mon, 3 Aug 2015 09:30:25 +0800
> Leo Yan <[email protected]> wrote:
>
> > Fix minor typo so that can pass correct pointer variable for
> > container_of().
>
> Looks good to me, applied to the docs tree. I also took the opportunity
> to eliminate the (now) needless line-splitting on the affected lines.

Yes, the line length is less than 78, so don't need splitting.

Thanks,
Leo Yan