2015-08-18 12:23:57

by Valentin Rothberg

Subject: c8sectpfe: Kconfig: select on undefined LIBELF_32

Hi Peter,

your commit 850a3f7d5911 ("[media] c8sectpfe: Add Kconfig and Makefile
for the driver") showed up in today's Linux next tree (i.e.,
next-20150818) adding the following lines of Kconfig code:

--- /dev/null
+++ b/drivers/media/platform/sti/c8sectpfe/Kconfig
@@ -0,0 +1,28 @@
+config DVB_C8SECTPFE
+ tristate "STMicroelectronics C8SECTPFE DVB support"
...skipping...
+ select LIBELF_32

LIBELF_32 is not defined in Kconfig so it turns out to be a NOOP. I
searched the LKML, but could not find any patch adding LIBELF_32. Is
there a patch queued somewhere to add this option?


I detected the issue with scripts/checkkconfigsymbols.py.

Kind regards,
Valentin

2015-08-25 16:44:00

by Peter Griffin

Subject: Re: c8sectpfe: Kconfig: select on undefined LIBELF_32

Hi Valentin,

On Tue, 18 Aug 2015, Valentin Rothberg wrote:

> Hi Peter,
>
> your commit 850a3f7d5911 ("[media] c8sectpfe: Add Kconfig and Makefile
> for the driver") showed up in today's Linux next tree (i.e.,
> next-20150818) adding the following lines of Kconfig code:
>
> --- /dev/null
> +++ b/drivers/media/platform/sti/c8sectpfe/Kconfig
> @@ -0,0 +1,28 @@
> +config DVB_C8SECTPFE
> + tristate "STMicroelectronics C8SECTPFE DVB support"
> ...skipping...
> + select LIBELF_32
>
> LIBELF_32 is not defined in Kconfig so it turns out to be a NOOP. I
> searched the LKML, but could not find any patch adding LIBELF_32. Is
> there a patch queued somewhere to add this option?

Sorry for the delay, I've been on holiday for the last 3 weeks.

Yes your correct this is unnecessary and was a legacy option left over
from a previous vendor kernel.

I've just sent a patch which removes it here: -
https://lkml.org/lkml/2015/8/25/502

regards,

Peter.