2015-08-06 08:56:15

by Viresh Kumar

Subject: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment

This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
Migrate to new 'set-state' interface") commit, but it wasn't.

Remove it now.

Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
Signed-off-by: Viresh Kumar <[email protected]>
---
Ralf:

Not sure how it was left out in my series, but I thought it should have
been caught by the compilers as the function hpet_set_mode doesn't exist
today.

Either merge it with the offending commit or keep it separate.

arch/mips/loongson64/loongson-3/hpet.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
index 950096e8d7cd..bf9f1a77f0e5 100644
--- a/arch/mips/loongson64/loongson-3/hpet.c
+++ b/arch/mips/loongson64/loongson-3/hpet.c
@@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
cd->name = "hpet";
cd->rating = 320;
cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
- cd->set_mode = hpet_set_mode;
cd->set_state_shutdown = hpet_set_state_shutdown;
cd->set_state_periodic = hpet_set_state_periodic;
cd->set_state_oneshot = hpet_set_state_oneshot;
--
2.4.0

2015-08-12 10:18:53

by Viresh Kumar

Subject: Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment

On 06-08-15, 14:25, Viresh Kumar wrote:
> This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
> Migrate to new 'set-state' interface") commit, but it wasn't.
>
> Remove it now.
>
> Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Ralf:
>
> Not sure how it was left out in my series, but I thought it should have
> been caught by the compilers as the function hpet_set_mode doesn't exist
> today.
>
> Either merge it with the offending commit or keep it separate.
>
> arch/mips/loongson64/loongson-3/hpet.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
> index 950096e8d7cd..bf9f1a77f0e5 100644
> --- a/arch/mips/loongson64/loongson-3/hpet.c
> +++ b/arch/mips/loongson64/loongson-3/hpet.c
> @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
> cd->name = "hpet";
> cd->rating = 320;
> cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
> - cd->set_mode = hpet_set_mode;
> cd->set_state_shutdown = hpet_set_state_shutdown;
> cd->set_state_periodic = hpet_set_state_periodic;
> cd->set_state_oneshot = hpet_set_state_oneshot;

Ping

--
viresh

2015-08-19 08:59:15

by Viresh Kumar

Subject: Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment

On 12-08-15, 15:48, Viresh Kumar wrote:
> On 06-08-15, 14:25, Viresh Kumar wrote:
> > This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
> > Migrate to new 'set-state' interface") commit, but it wasn't.
> >
> > Remove it now.
> >
> > Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
> > Signed-off-by: Viresh Kumar <[email protected]>
> > ---
> > Ralf:
> >
> > Not sure how it was left out in my series, but I thought it should have
> > been caught by the compilers as the function hpet_set_mode doesn't exist
> > today.
> >
> > Either merge it with the offending commit or keep it separate.
> >
> > arch/mips/loongson64/loongson-3/hpet.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
> > index 950096e8d7cd..bf9f1a77f0e5 100644
> > --- a/arch/mips/loongson64/loongson-3/hpet.c
> > +++ b/arch/mips/loongson64/loongson-3/hpet.c
> > @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
> > cd->name = "hpet";
> > cd->rating = 320;
> > cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
> > - cd->set_mode = hpet_set_mode;
> > cd->set_state_shutdown = hpet_set_state_shutdown;
> > cd->set_state_periodic = hpet_set_state_periodic;
> > cd->set_state_oneshot = hpet_set_state_oneshot;
>
> Ping

Another Ping !!

--
viresh

2015-08-19 10:14:16

by Ralf Baechle

Subject: Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment

On Wed, Aug 19, 2015 at 02:29:04PM +0530, Viresh Kumar wrote:

> Another Ping !!

Applied. Thanks!

Ralf