2015-08-19 03:18:01

by Axel Lin

Subject: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo

Just setting fixed_uV is not enough, the regulator core will also check
n_voltages setting. The fixed_uV only works when n_voltages is 1.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/qcom_smd-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 9d093ae..9c6167d 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {

static const struct regulator_desc pm8941_lnldo = {
.fixed_uV = 1740000,
+ .n_voltages = 1,
.ops = &rpm_smps_ldo_ops,
};

--
2.1.0

2015-08-19 16:04:40

by Bjorn Andersson

Subject: Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo

On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote:

> Just setting fixed_uV is not enough, the regulator core will also check
> n_voltages setting. The fixed_uV only works when n_voltages is 1.
>

Thanks, I missed that.

Reviewed-by: Bjorn Andersson <[email protected]>

> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 9d093ae..9c6167d 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
>
> static const struct regulator_desc pm8941_lnldo = {
> .fixed_uV = 1740000,
> + .n_voltages = 1,
> .ops = &rpm_smps_ldo_ops,
> };
>
> --
> 2.1.0
>
>
>