2015-08-21 10:05:27

by Valentin Rothberg

Subject: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule

The Kconfig option AVERAGE and its implementation has been removed by
commit f4e774f55fe0 ("average: remove out-of-line implementation").
Remove the dead build rule in lib/Makefile.

Signed-off-by: Valentin Rothberg <[email protected]>
---
I detected the issue with scripts/checkkconfigsymbols.py

lib/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/lib/Makefile b/lib/Makefile
index 51e1d761f0b9..f32d342b75de 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -143,8 +143,6 @@ obj-$(CONFIG_GENERIC_ATOMIC64) += atomic64.o

obj-$(CONFIG_ATOMIC64_SELFTEST) += atomic64_test.o

-obj-$(CONFIG_AVERAGE) += average.o
-
obj-$(CONFIG_CPU_RMAP) += cpu_rmap.o

obj-$(CONFIG_CORDIC) += cordic.o
--
1.9.1

2015-08-21 10:13:31

by Johannes Berg

Subject: Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule

On Fri, 2015-08-21 at 10:05 +0000, Valentin Rothberg wrote:
> The Kconfig option AVERAGE and its implementation has been removed by
> commit f4e774f55fe0 ("average: remove out-of-line implementation").
> Remove the dead build rule in lib/Makefile.

D'oh, sorry about that.

Reviewed-by: Johannes Berg <[email protected]>

[reproducing patch in full for netdev]

> Signed-off-by: Valentin Rothberg <[email protected]>
> ---
> I detected the issue with scripts/checkkconfigsymbols.py
>
> lib/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 51e1d761f0b9..f32d342b75de 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -143,8 +143,6 @@ obj-$(CONFIG_GENERIC_ATOMIC64) += atomic64.o
>
> obj-$(CONFIG_ATOMIC64_SELFTEST) += atomic64_test.o
>
> -obj-$(CONFIG_AVERAGE) += average.o
> -
> obj-$(CONFIG_CPU_RMAP) += cpu_rmap.o
>
> obj-$(CONFIG_CORDIC) += cordic.o
> --
> 1.9.1
>

2015-08-26 00:21:46

by David Miller

Subject: Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule

From: Johannes Berg <[email protected]>
Date: Fri, 21 Aug 2015 12:13:23 +0200

> On Fri, 2015-08-21 at 10:05 +0000, Valentin Rothberg wrote:
>> The Kconfig option AVERAGE and its implementation has been removed by
>> commit f4e774f55fe0 ("average: remove out-of-line implementation").
>> Remove the dead build rule in lib/Makefile.
>
> D'oh, sorry about that.
>
> Reviewed-by: Johannes Berg <[email protected]>
>
> [reproducing patch in full for netdev]

The full patch needs to be resubmitted to netdev so that it gets
queued up in patchwork, thanks.