2015-08-15 10:36:53

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH] rtlwifi: rtl8192ee: fix semicolon.cocci warnings

drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon
drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon
drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Larry Finger <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

phy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c
@@ -449,7 +449,7 @@ static void _rtl92ee_phy_set_txpower_by_
"Invalid RateSection %d in 2.4G,Rf %d,%dTx\n",
rate_section, path, txnum);
break;
- };
+ }
} else {
RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
"Invalid Band %d\n", band);
@@ -489,7 +489,7 @@ static u8 _rtl92ee_phy_get_txpower_by_ra
"Invalid RateSection %d in 2.4G,Rf %d,%dTx\n",
rate_section, path, txnum);
break;
- };
+ }
} else {
RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
"Invalid Band %d()\n", band);
@@ -853,7 +853,7 @@ static u8 _rtl92ee_get_rate_section_inde
else if (regaddr >= 0xE20 && regaddr <= 0xE4C)
index = (u8)((regaddr - 0xE20) / 4);
break;
- };
+ }
return index;
}


2015-08-15 16:47:56

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8192ee: fix semicolon.cocci warnings

On 08/15/2015 05:36 AM, kbuild test robot wrote:
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> CC: Larry Finger <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>

Signed-off-by: Larry Finger <[email protected]>

Larry

> ---
>
> phy.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c
> @@ -449,7 +449,7 @@ static void _rtl92ee_phy_set_txpower_by_
> "Invalid RateSection %d in 2.4G,Rf %d,%dTx\n",
> rate_section, path, txnum);
> break;
> - };
> + }
> } else {
> RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
> "Invalid Band %d\n", band);
> @@ -489,7 +489,7 @@ static u8 _rtl92ee_phy_get_txpower_by_ra
> "Invalid RateSection %d in 2.4G,Rf %d,%dTx\n",
> rate_section, path, txnum);
> break;
> - };
> + }
> } else {
> RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
> "Invalid Band %d()\n", band);
> @@ -853,7 +853,7 @@ static u8 _rtl92ee_get_rate_section_inde
> else if (regaddr >= 0xE20 && regaddr <= 0xE4C)
> index = (u8)((regaddr - 0xE20) / 4);
> break;
> - };
> + }
> return index;
> }
>
>

2015-08-25 12:11:38

by Kalle Valo

[permalink] [raw]
Subject: Re: rtlwifi: rtl8192ee: fix semicolon.cocci warnings


> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> CC: Larry Finger <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo