2015-08-28 19:31:14

by Stephen Boyd

Subject: [PATCH] spmi: pmic-arb: u8 <= 0xff is always true

Silences this static checker warning:

drivers/spmi/spmi-pmic-arb.c:363
pmic_arb_write_cmd() warn: always true condition
'(opc <= 255) => (0-255 <= 255)'

Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/spmi/spmi-pmic-arb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 5e834bd23c09..c7aa6f1a898e 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -360,7 +360,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
opc = PMIC_ARB_OP_EXT_WRITE;
else if (opc >= 0x30 && opc <= 0x37)
opc = PMIC_ARB_OP_EXT_WRITEL;
- else if (opc >= 0x80 && opc <= 0xFF)
+ else if (opc >= 0x80)
opc = PMIC_ARB_OP_ZERO_WRITE;
else
return -EINVAL;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2015-08-28 22:34:42

by Bjorn Andersson

Subject: Re: [PATCH] spmi: pmic-arb: u8 <= 0xff is always true

On Fri 28 Aug 12:31 PDT 2015, Stephen Boyd wrote:

> Silences this static checker warning:
>
> drivers/spmi/spmi-pmic-arb.c:363
> pmic_arb_write_cmd() warn: always true condition
> '(opc <= 255) => (0-255 <= 255)'
>
> Cc: Andy Gross <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn