2015-11-01 10:44:10

by Stephen Rothwell

Subject: linux-next: build failure after merge of the device-mapper tree

Hi all,

After merging the device-mapper tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/md/dm-mpath.c: In function 'multipath_prepare_ioctl':
drivers/md/dm-mpath.c:1570:41: error: 'cmd' undeclared (first use in this function)
int err = scsi_verify_blk_ioctl(NULL, cmd);
^

Caused by commit

21a2807bc3ff ("dm: refactor ioctl handling")

I have used the device-mapper tree from next-20151022 for today.

--
Cheers,
Stephen Rothwell [email protected]

2015-11-01 13:44:16

by Mike Snitzer

Subject: Re: linux-next: build failure after merge of the device-mapper tree

On Sun, Nov 01 2015 at 5:43am -0500,
Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> After merging the device-mapper tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/md/dm-mpath.c: In function 'multipath_prepare_ioctl':
> drivers/md/dm-mpath.c:1570:41: error: 'cmd' undeclared (first use in this function)
> int err = scsi_verify_blk_ioctl(NULL, cmd);
> ^
>
> Caused by commit
>
> 21a2807bc3ff ("dm: refactor ioctl handling")
>
> I have used the device-mapper tree from next-20151022 for today.

There was a ~3 hour window yesterday where this was broken. I resolved
it almost 12 hours prior to you having sent this mail.

Do you batch update the trees you pull into linux-next at some point
much earlier in the day?

If/when you do hit a tree that is clearly broken at the time you
pulled: do you attempt to re-pull to get the latest _before_ reverting
to some prior linux-next version of the tree in question?

Anyway, sorry the device-mapper tree was broken for a small window of
time yesterday -- but of course linux-next pulled during that window ;)