2015-11-02 09:03:44

by Valentin Rothberg

[permalink] [raw]
Subject: b43: removal of B43_PCMCIA

Hi Rafal,

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43
driver") has shown up in today's Linux next tree (i.e., next-20151102)
and removes the Kconfig option B43_PCMCIA and references on it in the
code. However the commit misses to remove the following reference:

drivers/net/wireless/b43/main.c:5829:#ifdef CONFIG_B43_PCMCIA
drivers/net/wireless/b43/main.c-5830- feat_pcmcia = "M";
drivers/net/wireless/b43/main.c-5831-#endif

Is it by purpose? In case not, I can send a trivial patch to remove
those three lines.

I detected the issue with scripts/checkkconfigsymbols.py.

Kind regards,
Valentin


2015-11-02 09:05:47

by Rafał Miłecki

[permalink] [raw]
Subject: Re: b43: removal of B43_PCMCIA

On 2 November 2015 at 10:03, Valentin Rothberg
<[email protected]> wrote:
> your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43
> driver") has shown up in today's Linux next tree (i.e., next-20151102)
> and removes the Kconfig option B43_PCMCIA and references on it in the
> code. However the commit misses to remove the following reference:
>
> drivers/net/wireless/b43/main.c:5829:#ifdef CONFIG_B43_PCMCIA
> drivers/net/wireless/b43/main.c-5830- feat_pcmcia = "M";
> drivers/net/wireless/b43/main.c-5831-#endif
>
> Is it by purpose? In case not, I can send a trivial patch to remove
> those three lines.
>
> I detected the issue with scripts/checkkconfigsymbols.py.

Nice catch, please remove that line from main.c.

--
Rafał