2015-11-03 14:34:21

by Christoffer Dall

[permalink] [raw]
Subject: Re: [PATCH] ARM: add v7 LPAE multi-platform defconfig

On Tue, Oct 27, 2015 at 10:35:07PM +0800, Alison Wang wrote:
> v7 LPAE multi-platform defconfig is based on v7 multi-platform
> defconfig and adds LPAE support.
>
> This defconfig is verified on LS1021A which enables GIANFAR,
> I2C, WATCHDOG, AUDIO, EDMA and DSPI drivers, etc.
>
> Signed-off-by: Alison Wang <[email protected]>

I think this would be great if it also had:

CONFIG_ARCH_VIRT=y
CONFIG_VIRTUALIZATION=y
CONFIG_KVM=y

That would allow it to be used for KVM testing both as host and guest.

FWIW, I just tried booting this on my TC2, but I don't get any output
from there. Is it supposed to work on this platform? If not, why not?

Thanks,
-Christoffer


2015-11-04 03:32:46

by Huan Wang

[permalink] [raw]
Subject: RE: [PATCH] ARM: add v7 LPAE multi-platform defconfig

> On Tue, Oct 27, 2015 at 10:35:07PM +0800, Alison Wang wrote:
> > v7 LPAE multi-platform defconfig is based on v7 multi-platform
> > defconfig and adds LPAE support.
> >
> > This defconfig is verified on LS1021A which enables GIANFAR, I2C,
> > WATCHDOG, AUDIO, EDMA and DSPI drivers, etc.
> >
> > Signed-off-by: Alison Wang <[email protected]>
>
> I think this would be great if it also had:
>
> CONFIG_ARCH_VIRT=y
> CONFIG_VIRTUALIZATION=y
> CONFIG_KVM=y
>
> That would allow it to be used for KVM testing both as host and guest.
>
> FWIW, I just tried booting this on my TC2, but I don't get any output
> from there. Is it supposed to work on this platform? If not, why not?
>
[Alison Wang] One question, does TC2 support LPAE? If so, we could try to
find the reason and add it in this defconfig for armv7 LPAE support.


Best Regards,
Alison Wang

2015-11-04 08:57:09

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ARM: add v7 LPAE multi-platform defconfig

On Wednesday 04 November 2015 03:17:06 Huan Wang wrote:
> > On Tue, Oct 27, 2015 at 10:35:07PM +0800, Alison Wang wrote:
> > > v7 LPAE multi-platform defconfig is based on v7 multi-platform
> > > defconfig and adds LPAE support.
> > >
> > > This defconfig is verified on LS1021A which enables GIANFAR, I2C,
> > > WATCHDOG, AUDIO, EDMA and DSPI drivers, etc.
> > >
> > > Signed-off-by: Alison Wang <[email protected]>
> >
> > I think this would be great if it also had:
> >
> > CONFIG_ARCH_VIRT=y
> > CONFIG_VIRTUALIZATION=y
> > CONFIG_KVM=y
> >
> > That would allow it to be used for KVM testing both as host and guest.
> >
> > FWIW, I just tried booting this on my TC2, but I don't get any output
> > from there. Is it supposed to work on this platform? If not, why not?
> >
> [Alison Wang] One question, does TC2 support LPAE? If so, we could try to
> find the reason and add it in this defconfig for armv7 LPAE support.

Yes, I think we should enable all platforms that we enable in the normal
multi_v7_defconfig, if we decide to add a new one. Just remove the platforms
that are based on Cortex-A5/A8/A9, Scorpion or PJ4 rather than A7/A12/A15/A17
or Krait.

Arnd

2015-11-06 06:03:16

by Huan Wang

[permalink] [raw]
Subject: RE: [PATCH] ARM: add v7 LPAE multi-platform defconfig

> On Wednesday 04 November 2015 03:17:06 Huan Wang wrote:
> > > On Tue, Oct 27, 2015 at 10:35:07PM +0800, Alison Wang wrote:
> > > > v7 LPAE multi-platform defconfig is based on v7 multi-platform
> > > > defconfig and adds LPAE support.
> > > >
> > > > This defconfig is verified on LS1021A which enables GIANFAR, I2C,
> > > > WATCHDOG, AUDIO, EDMA and DSPI drivers, etc.
> > > >
> > > > Signed-off-by: Alison Wang <[email protected]>
> > >
> > > I think this would be great if it also had:
> > >
> > > CONFIG_ARCH_VIRT=y
> > > CONFIG_VIRTUALIZATION=y
> > > CONFIG_KVM=y
> > >
> > > That would allow it to be used for KVM testing both as host and
> guest.
> > >
> > > FWIW, I just tried booting this on my TC2, but I don't get any
> > > output from there. Is it supposed to work on this platform? If not,
> why not?
> > >
> > [Alison Wang] One question, does TC2 support LPAE? If so, we could try
> > to find the reason and add it in this defconfig for armv7 LPAE support.
>
> Yes, I think we should enable all platforms that we enable in the normal
> multi_v7_defconfig, if we decide to add a new one. Just remove the
> platforms that are based on Cortex-A5/A8/A9, Scorpion or PJ4 rather than
> A7/A12/A15/A17 or Krait.
>
[Alison Wang] Thanks for your advice. I will try to prepare a new one according
to your advice.


Best Regards,
Alison Wang